Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MJLINK-85] Fix issue with single quoting every argument #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MJLINK-85] Fix issue with single quoting every argument #212

wants to merge 1 commit into from

Commits on Jul 31, 2024

  1. [MJLINK-85] Fix issue with single quoting every argument 

    Each argument is first double quoted, but because of the default
configuration of `org.apache.maven.shared.utils.cli.shell.Shell`
is also single quoted on top. This leads to a shell command line
which is not executable.

To fix this, leave the double quoting of each argument as it was,
disable the single quoting of each argument with `Shell` configuration
and wrap all the arguments as a whole string with single quotes, so
that they are passed into `bin/sh -c`, example:

```
bin/sh -c '"--module-path" "foo:bar" "--add-modules" "mod1,mod2"'
```
    @matriv
    matriv committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a5982bb View commit details
    Browse the repository at this point in the history