Nightly pekko 1.1 tests #181
Conversation
pjfanning
commented
Apr 25, 2024
pjfanning
commented
- When I run these locally I get 2 errors
- We need to keep better eye on whether pekko 1.1 breaks things
- also removes the support of migration-tool branch which no longer exists
pjfanning
requested review from
raboof,
He-Pin,
nvollmar,
mdedetrich and
Roiocam
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 0 * * *" |
There was a problem hiding this comment.
Should we defer the time after pekko nightly published？
There was a problem hiding this comment.
makes sense - I have changed this to run at 4am
|
Example failure. I don't know if this is a new check in pekko-persistence. |
| uses: coursier/cache-action@v6 | ||
|
|
||
| - name: Run tests with Scala ${{ matrix.scala-version }} and Java ${{ matrix.java-version }} | ||
| run: sbt -Dpekko.build.pekko.version=main "++${{ matrix.scala-version }} test" ${{ matrix.sbt-opts }} |
There was a problem hiding this comment.
I need to run the test
There was a problem hiding this comment.
Package will run the test too,IIRC, what about test;package?
There was a problem hiding this comment.
why do I need to package? it is the tests that we need to run
There was a problem hiding this comment.
Let's merge this then, anyway this pr is a great addition
|
new test issues seem to be due to apache/pekko#887 I can come back and do another PR to try to update the test |
|
I actually think we might need to revert apache/pekko#887 |
|
I think the code is right , a delay 0 will be a busy loop, and as the scheduler tick at 1ms, so how about change the delay to 1ms？ |
