Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Session Management in Apache Roller #148

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Enhanced Session Management in Apache Roller #148

merged 5 commits into from
Feb 1, 2025

Conversation

snoopdave
Copy link
Contributor

@snoopdave snoopdave commented Jan 20, 2025 •
edited
Loading

This PR introduces improved session management capabilities to Roller:

  • Added RollerLoginSessionManager to provide centralized session tracking
  • Enhanced RollerSession to integrate with the new session management system
  • Updated UserEdit to handle session state changes
  • Added comprehensive test coverage for new functionality

The changes provide better control over user sessions and improve overall application reliability.

Testing:

  • Added RollerLoginSessionManagerTest with full coverage of new functionality
  • Added RollerSessionTest to verify session behavior
  • All existing tests pass

@snoopdave snoopdave mentioned this pull request Jan 20, 2025
Closed
mbien
mbien approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! unfortunately I haven't had time to test it manually - but tests look good too.

app/src/main/java/org/apache/roller/weblogger/util/cache/CacheHandlerAdapter.java Outdated Show resolved Hide resolved
@snoopdave snoopdave changed the title Session management improvements simple Enhanced Session Management in Apache Roller Jan 26, 2025
@snoopdave snoopdave merged commit cd5139a into master Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snoopdave @mbien