Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence missing event #3621

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Oct 26, 2023

Close: #3397
Context: #3562

1. Explain what the PR does

257f36a fix(ebpf): change error to debug level
5850446 fix(ebpf): cancel dependencies of the canceled one
4db6a48 chore(flags): remove leftover

257f36a fix(ebpf): change error to debug level

Some GKE kernels lack the CONFIG_KALLSYMS_ALL enabled, so this level
change is to silence the error related to missing kernel symbols. This
is a workaround until the 'sys_call_table' address can be retrieved
from the kernel in a way other than using '/proc/kallsyms' (see #3397).
At that point, the level should be changed back to 'error' again.

5850446 fix(ebpf): cancel dependencies of the canceled one

Context: #3495
https://github.com/aquasecurity/tracee/actions/runs/6475371851/job/17582516454#step:5:42

4db6a48 chore(flags): remove leftover

After the changes of #3262, at this stage, policies.Map() length is
always greater than 0.

2. Explain how to test it

3. Other comments

After the changes of aquasecurity#3262, at this stage, policies.Map() length is
always greater than 0.
Some GKE kernels lack the CONFIG_KALLSYMS_ALL enabled, so this level
change is to silence the error related to missing kernel symbols. This
is a workaround until the 'sys_call_table' address can be retrieved
from the kernel in a way other than using '/proc/kallsyms' (see aquasecurity#3397).
At that point, the level should be changed back to 'error' again.
@rafaeldtinoco
Copy link
Contributor

Reviewing this one now (hooked_syscall was already merged).

Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sent you a gist with a very minor chore. we already spoke about it so LGTM, merge at your will.

@geyslan geyslan merged commit 7f64cfc into aquasecurity:main Oct 30, 2023
3 checks passed
@geyslan geyslan deleted the 3397-silence-missing-event branch October 31, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracee errors/warns on gke
2 participants