Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence missing event #3621

Merged
merged 4 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions pkg/cmd/flags/policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,25 +320,5 @@ func CreatePolicies(policyScopeMap PolicyScopeMap, policyEventsMap PolicyEventMa
}
}

if len(policies.Map()) == 0 {
// if nothing was set, let us consider it as a single default policy
eventFilter := eventFilter{
Equal: []string{},
NotEqual: []string{},
}

var err error
newPolicy := policy.NewPolicy()
newPolicy.EventsToTrace, err = prepareEventsToTrace(eventFilter, eventsNameToID)
if err != nil {
return nil, err
}

err = policies.Add(newPolicy)
if err != nil {
return nil, err
}
}

return policies, nil
}
24 changes: 23 additions & 1 deletion pkg/ebpf/tracee.go
Original file line number Diff line number Diff line change
Expand Up @@ -955,16 +955,38 @@ func (t *Tracee) checkUnavailableKSymbols(eventsState map[events.ID]events.Event
// missing, it will cancel their event with informative error message.
func (t *Tracee) validateKallsymsDependencies() {
unavKSymbols := t.checkUnavailableKSymbols(t.eventsState)
depsToCancel := make(map[events.ID]string)

// Cancel events with unavailable symbols dependencies
for eventToCancel, missingDepSyms := range unavKSymbols {
eventNameToCancel := events.Core.GetDefinitionByID(eventToCancel).GetName()
logger.Errorw(
logger.Debugw(
"Event canceled because of missing kernel symbol dependency",
"missing symbols", missingDepSyms, "event", eventNameToCancel,
)

delete(t.eventsState, eventToCancel)

// Find all events that depend on eventToCancel
for eventID := range t.eventsState {
depsIDs := events.Core.GetDefinitionByID(eventID).GetDependencies().GetIDs()
for _, depID := range depsIDs {
if depID == eventToCancel {
depsToCancel[eventID] = eventNameToCancel
}
}
}

// Cancel all events that require eventToCancel
for eventID, depEventName := range depsToCancel {
logger.Debugw(
"Event canceled because it depends on an previously canceled event",
"event", events.Core.GetDefinitionByID(eventID).GetName(),
"dependency", depEventName,
)

delete(t.eventsState, eventID)
}
}
}

Expand Down