Skip to content

Conversation

@bluepal-prasanthi-moparthi
Copy link
Collaborator

@bluepal-prasanthi-moparthi bluepal-prasanthi-moparthi commented Dec 1, 2025

… without V8


Note

Gate V8-dependent tests behind a runtime V8 check (with helper), refactor tasks tests to use per-db contexts, add V1 skips for V8 cases, and update the CI ArangoDB image tag.

  • Tests (v2):
    • V8 gating: Introduce requireV8Enabled in v2/tests/util_test.go and apply to V8-dependent tests (asyncjob_test.go pending/cleanup cases, database_transactionsjs_test.go, database_query_test.go UDFs, foxx_test.go, tasks_test.go).
    • Tasks tests refactor: Run against created databases via WithDatabase, pass db.Name() to task APIs, and restructure per-test contexts.
  • Tests (v1):
    • Add V8-related skips by calling skipBelowVersion(..., "4.0") in test/asyncjob_test.go and test/database_transaction_test.go.
  • CI:
    • Update arangodbImage default in .circleci/config.yml to public.ecr.aws/...:2025-12-01-devel-d759089-amd64.

Written by Cursor Bugbot for commit f0229ed. This will update automatically on new commits. Configure here.

@cla-bot cla-bot bot added the cla-signed label Dec 1, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

skipResilientSingle(t)

// for disabling v8 tests
skipBelowVersion(c, "4.0", t)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: V1 tests use inverted version skip logic for V8

The V1 tests use skipBelowVersion(c, "4.0", t) to disable V8-dependent tests, but this logic is inverted. skipBelowVersion skips tests when version is less than 4.0 and runs them when version is >= 4.0. Since V8 is being removed in version 4.0+, the tests will be skipped on older versions where V8 is present and run on newer versions where V8 is absent — the exact opposite of the intended behavior. The codebase has skipFromVersion which skips tests for versions >= the specified version, which appears to be the correct function for this use case. The V2 tests correctly use requireV8Enabled for dynamic checking.

Additional Locations (2)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants