Skip to content

Disable V8-dependent API tests for V2 since future arangods will ship… #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable V8-dependent API tests for V2 since future arangods will ship… #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a320fe0
Disable V8-dependent API tests for V2 since future arangods will ship…
bluepal-prasanthi-moparthi Dec 1, 2025
f0229ed
changes in config for arangodbImage and test cahges in V1
bluepal-prasanthi-moparthi Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ parameters:
default: "gcr.io/gcr-for-testing/golang:1.24.9"
arangodbImage:
type: string
default: "gcr.io/gcr-for-testing/arangodb/enterprise-preview:latest"
default: "public.ecr.aws/b0b8h2r4/enterprise-preview:2025-12-01-devel-d759089-amd64"
alpineImage:
type: string
default: "gcr.io/gcr-for-testing/alpine:3.21"
Expand Down
9 changes: 9 additions & 0 deletions test/asyncjob_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ func TestAsyncJobListPending(t *testing.T) {
EnsureVersion(t, ctx, c).CheckVersion(MinimumVersion("3.11.1"))
skipResilientSingle(t)

// for disabling v8 tests
skipBelowVersion(c, "4.0", t)
Copy link

@cursor cursor bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: V1 tests use inverted version skip logic for V8

The V1 tests use skipBelowVersion(c, "4.0", t) to disable V8-dependent tests, but this logic is inverted. skipBelowVersion skips tests when version is less than 4.0 and runs them when version is >= 4.0. Since V8 is being removed in version 4.0+, the tests will be skipped on older versions where V8 is present and run on newer versions where V8 is absent — the exact opposite of the intended behavior. The codebase has skipFromVersion which skips tests for versions >= the specified version, which appears to be the correct function for this use case. The V2 tests correctly use requireV8Enabled for dynamic checking.

Additional Locations (2)

Fix in Cursor Fix in Web


db := ensureDatabase(ctx, c, databaseName("db", "async"), nil, t)
defer func() {
err := db.Remove(ctx)
Expand Down Expand Up @@ -254,6 +257,9 @@ func TestAsyncJobDelete(t *testing.T) {
})

t.Run("delete pending job", func(t *testing.T) {
// for disabling v8 tests
skipBelowVersion(c, "4.0", t)

idTransaction := runLongRequest(t, ctxAsync, db, 10, col.Name())
require.NotEmpty(t, idTransaction)

Expand All @@ -275,6 +281,9 @@ func TestAsyncJobDelete(t *testing.T) {
})

t.Run("delete expired jobs", func(t *testing.T) {
// for disabling v8 tests
skipBelowVersion(c, "4.0", t)

idTransaction := runLongRequest(t, ctxAsync, db, 10, col.Name())
require.NotEmpty(t, idTransaction)

Expand Down
4 changes: 3 additions & 1 deletion test/database_transaction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ import (

func TestDatabaseTransaction(t *testing.T) {
c := createClient(t, nil)
skipBelowVersion(c, "3.2", t)
// for disabling v8 tests
skipBelowVersion(c, "4.0", t)

db := ensureDatabase(nil, c, "transaction_test", nil, t)
defer func() {
err := db.Remove(nil)
Expand Down
4 changes: 4 additions & 0 deletions v2/tests/asyncjob_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ func TestAsyncJobListPending(t *testing.T) {
skipBelowVersion(client, ctx, "3.11.1", t)
skipResilientSingleMode(t)

requireV8Enabled(client, ctx, t)

ctxAsync := connection.WithAsync(context.Background())

idTransaction := runLongRequest(t, ctxAsync, db, 2, col.Name())
Expand Down Expand Up @@ -254,6 +256,7 @@ func TestAsyncJobDelete(t *testing.T) {
})

t.Run("delete pending job", func(t *testing.T) {
requireV8Enabled(client, ctx, t)
idTransaction := runLongRequest(t, ctxAsync, db, 10, col.Name())
require.NotEmpty(t, idTransaction)

Expand All @@ -275,6 +278,7 @@ func TestAsyncJobDelete(t *testing.T) {
})

t.Run("delete expired jobs", func(t *testing.T) {
requireV8Enabled(client, ctx, t)
idTransaction := runLongRequest(t, ctxAsync, db, 10, col.Name())
require.NotEmpty(t, idTransaction)

Expand Down
1 change: 1 addition & 0 deletions v2/tests/database_query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,6 +1271,7 @@ func Test_UserDefinedFunctions(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
requireV8Enabled(client, ctx, tb)
// Define UDF details
namespace := "myfunctions::temperature::" + StringWithCharset(16, charset)
functionName := namespace + "::celsiustofahrenheit"
Expand Down
2 changes: 1 addition & 1 deletion v2/tests/database_transactionsjs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func Test_DatabaseTransactionsJS(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
WithDatabase(t, client, nil, func(db arangodb.Database) {
WithCollectionV2(t, db, nil, func(col arangodb.Collection) {

requireV8Enabled(client, context.Background(), t)
t.Run("Transaction ReturnValue", func(t *testing.T) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, t testing.TB) {
txJSOptions := arangodb.TransactionJSOptions{
Expand Down
3 changes: 3 additions & 0 deletions v2/tests/foxx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func Test_FoxxItzpapalotlService(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
requireV8Enabled(client, ctx, tb)
if os.Getenv("TEST_CONNECTION") == "vst" {
skipBelowVersion(client, ctx, "3.6", t)
}
Expand Down Expand Up @@ -298,6 +299,7 @@ func Test_ListInstalledFoxxServices(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
requireV8Enabled(client, ctx, tb)
services, err := client.ListInstalledFoxxServices(ctx, db.Name(), nil)
require.NoError(t, err)
require.NotEmpty(t, services)
Expand Down Expand Up @@ -325,6 +327,7 @@ func Test_GetInstalledFoxxService(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
requireV8Enabled(client, ctx, tb)
mount := "/_api/foxx"
serviceDetails, err := client.GetInstalledFoxxService(ctx, db.Name(), &mount)
require.NoError(t, err)
Expand Down
223 changes: 116 additions & 107 deletions v2/tests/tasks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,136 +53,145 @@ type TaskParams struct {

func Test_CreateNewTask(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
dbName := "_system"
testCases := map[string]*arangodb.TaskOptions{
"taskWithParams": {
Name: utils.NewType("taskWithParams"),
Command: utils.NewType("(function(params) { require('@arangodb').print(params); })(params)"),
Period: utils.NewType(int64(2)),
Params: map[string]interface{}{
"test": "hello",
},
},
"taskWithoutParams": {
Name: utils.NewType("taskWithoutParams"),
Command: utils.NewType("(function() { require('@arangodb').print('Hello'); })()"),
Period: utils.NewType(int64(2)),
},
}

for name, options := range testCases {
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
createdTask, err := client.CreateTask(ctx, dbName, *options)
require.NoError(t, err)
require.NotNil(t, createdTask)
require.Equal(t, name, *createdTask.Name())
t.Logf("Params: %v", options.Params)
// Proper params comparison
// Check parameters
if options.Params != nil {
var params map[string]interface{}
err = createdTask.Params(&params)

if err != nil {
t.Logf("WARNING: Could not fetch task params (unsupported feature?): %v", err)
} else if len(params) == 0 {
t.Logf("WARNING: Task params exist but returned empty (ArangoDB limitation?)")
} else {
// Only check if params are actually returned
require.Equal(t, options.Params, params)
}
requireV8Enabled(client, ctx, tb)
testCases := map[string]*arangodb.TaskOptions{
"taskWithParams": {
Name: utils.NewType("taskWithParams"),
Command: utils.NewType("(function(params) { require('@arangodb').print(params); })(params)"),
Period: utils.NewType(int64(2)),
Params: map[string]interface{}{
"test": "hello",
},
},
"taskWithoutParams": {
Name: utils.NewType("taskWithoutParams"),
Command: utils.NewType("(function() { require('@arangodb').print('Hello'); })()"),
Period: utils.NewType(int64(2)),
},
}

taskInfo, err := client.Task(ctx, dbName, *createdTask.ID())
require.NoError(t, err)
require.NotNil(t, taskInfo)
require.Equal(t, name, *taskInfo.Name())

tasks, err := client.Tasks(ctx, dbName)
require.NoError(t, err)
require.NotNil(t, tasks)
require.Greater(t, len(tasks), 0, "Expected at least one task to be present")
t.Logf("Found tasks: %v", tasks)
if len(tasks) > 0 && tasks[0].ID() != nil {
t.Logf("Task Id to be removed: %s\n", *tasks[0].ID())
} else {
t.Logf("Task Id to be removed: <nil>")
}
if id := createdTask.ID(); id != nil {
require.NoError(t, client.RemoveTask(ctx, dbName, *id))
t.Logf("Task %s removed successfully", *id)
} else {
t.Logf("Task ID is nil")
for name, options := range testCases {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
createdTask, err := client.CreateTask(ctx, db.Name(), *options)
require.NoError(t, err)
require.NotNil(t, createdTask)
require.Equal(t, name, *createdTask.Name())
t.Logf("Params: %v", options.Params)
// Proper params comparison
// Check parameters
if options.Params != nil {
var params map[string]interface{}
err = createdTask.Params(&params)

if err != nil {
t.Logf("WARNING: Could not fetch task params (unsupported feature?): %v", err)
} else if len(params) == 0 {
t.Logf("WARNING: Task params exist but returned empty (ArangoDB limitation?)")
} else {
// Only check if params are actually returned
require.Equal(t, options.Params, params)
}
}

taskInfo, err := client.Task(ctx, db.Name(), *createdTask.ID())
require.NoError(t, err)
require.NotNil(t, taskInfo)
require.Equal(t, name, *taskInfo.Name())

tasks, err := client.Tasks(ctx, db.Name())
require.NoError(t, err)
require.NotNil(t, tasks)
require.Greater(t, len(tasks), 0, "Expected at least one task to be present")
t.Logf("Found tasks: %v", tasks)
if len(tasks) > 0 && tasks[0].ID() != nil {
t.Logf("Task Id to be removed: %s\n", *tasks[0].ID())
} else {
t.Logf("Task Id to be removed: <nil>")
}
if id := createdTask.ID(); id != nil {
require.NoError(t, client.RemoveTask(ctx, db.Name(), *id))
t.Logf("Task %s removed successfully", *id)
} else {
t.Logf("Task ID is nil")
}
})
}
})
}
})
}, WrapOptions{
Parallel: utils.NewType(false),
})
}

func Test_ValidationsForCreateNewTask(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
dbName := "_system"
testCases := map[string]*arangodb.TaskOptions{
"taskWithoutCommand": {
Name: utils.NewType("taskWithoutCommand"),
Period: utils.NewType(int64(2)),
},
"taskWithoutPeriod": nil,
}

for name, options := range testCases {
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
var err error
if options == nil {
_, err = client.CreateTask(ctx, dbName, arangodb.TaskOptions{})
} else {
_, err = client.CreateTask(ctx, dbName, *options)
requireV8Enabled(client, ctx, tb)
testCases := map[string]*arangodb.TaskOptions{
"taskWithoutCommand": {
Name: utils.NewType("taskWithoutCommand"),
Period: utils.NewType(int64(2)),
},
"taskWithoutPeriod": nil,
}

require.Error(t, err)
t.Logf("Expected error for task '%s': %v", name, err)
for name, options := range testCases {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
var err error
if options == nil {
_, err = client.CreateTask(ctx, db.Name(), arangodb.TaskOptions{})
} else {
_, err = client.CreateTask(ctx, db.Name(), *options)
}

require.Error(t, err)
t.Logf("Expected error for task '%s': %v", name, err)
})
}
})
}

})
}, WrapOptions{
Parallel: utils.NewType(false),
})
}

func Test_TaskCreationWithId(t *testing.T) {
Wrap(t, func(t *testing.T, client arangodb.Client) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
dbName := "_system"
taskID := "test-task-id" + StringWithCharset(16, charset)
options := &arangodb.TaskOptions{
ID: &taskID, // Optional if CreateTaskWithID sets it, but safe to keep
Name: utils.NewType("TestTaskWithID"),
Command: utils.NewType("console.log('This is a test task with ID');"),
Period: utils.NewType(int64(5)),
}

// Create the task with explicit ID
task, err := client.CreateTaskWithID(ctx, dbName, taskID, *options)
require.NoError(t, err, "Expected task creation to succeed")
require.NotNil(t, task, "Expected task to be non-nil")
require.Equal(t, taskID, *task.ID(), "Task ID mismatch")
require.Equal(t, *options.Name, *task.Name(), "Task Name mismatch")

// Retrieve and validate
retrievedTask, err := client.Task(ctx, dbName, taskID)
require.NoError(t, err, "Expected task retrieval to succeed")
require.NotNil(t, retrievedTask, "Expected retrieved task to be non-nil")
require.Equal(t, taskID, *retrievedTask.ID(), "Retrieved task ID mismatch")
require.Equal(t, *options.Name, *retrievedTask.Name(), "Retrieved task Name mismatch")

_, err = client.CreateTaskWithID(ctx, dbName, taskID, *options)
require.Error(t, err, "Creating a duplicate task should fail")

// Clean up
err = client.RemoveTask(ctx, dbName, taskID)
require.NoError(t, err, "Expected task removal to succeed")
WithDatabase(t, client, nil, func(db arangodb.Database) {
withContextT(t, defaultTestTimeout, func(ctx context.Context, tb testing.TB) {
requireV8Enabled(client, ctx, tb)
taskID := "test-task-id" + StringWithCharset(16, charset)
options := &arangodb.TaskOptions{
ID: &taskID, // Optional if CreateTaskWithID sets it, but safe to keep
Name: utils.NewType("TestTaskWithID"),
Command: utils.NewType("console.log('This is a test task with ID');"),
Period: utils.NewType(int64(5)),
}

// Create the task with explicit ID
task, err := client.CreateTaskWithID(ctx, db.Name(), taskID, *options)
require.NoError(t, err, "Expected task creation to succeed")
require.NotNil(t, task, "Expected task to be non-nil")
require.Equal(t, taskID, *task.ID(), "Task ID mismatch")
require.Equal(t, *options.Name, *task.Name(), "Task Name mismatch")

// Retrieve and validate
retrievedTask, err := client.Task(ctx, db.Name(), taskID)
require.NoError(t, err, "Expected task retrieval to succeed")
require.NotNil(t, retrievedTask, "Expected retrieved task to be non-nil")
require.Equal(t, taskID, *retrievedTask.ID(), "Retrieved task ID mismatch")
require.Equal(t, *options.Name, *retrievedTask.Name(), "Retrieved task Name mismatch")

_, err = client.CreateTaskWithID(ctx, db.Name(), taskID, *options)
require.Error(t, err, "Creating a duplicate task should fail")

// Clean up
err = client.RemoveTask(ctx, db.Name(), taskID)
require.NoError(t, err, "Expected task removal to succeed")
})
})
})
}
Loading