Skip to content

fix: S3 signer, ROS1 bag writer/reader, and extract CLI for Foxglove-compatible bag #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhexuany merged 6 commits into from
Feb 8, 2026
Merged

fix: S3 signer, ROS1 bag writer/reader, and extract CLI for Foxglove-compatible bag #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0d1a3f
fix(s3): include port in Host header for non-standard ports
zhexuany Feb 8, 2026
04766ac
fix(s3): correct SigV4 canonical request per AWS spec
zhexuany Feb 8, 2026
17a9bf7
fix(bag): handle OP_CHUNK records in StreamingBagParser
zhexuany Feb 8, 2026
ac3302b
test(bag): add real fixture integration tests for StreamingBagParser
zhexuany Feb 8, 2026
ccd1897
test: fix clippy lint for len_zero comparison
zhexuany Feb 8, 2026
18f7908
style: remove redundant path prefixes in CLI code
zhexuany Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions robocodec-cli/src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

//! CLI utilities for the robocodec command-line interface.

use robocodec::RoboReader;

pub mod output;
pub mod progress;
pub mod time;
Expand All @@ -18,9 +20,9 @@ pub use time::{format_duration, format_timestamp, parse_time_range};
///
/// Convenience wrapper around `RoboReader::open` that provides better
/// error messages for invalid paths.
pub fn open_reader(path: &std::path::Path) -> Result<robocodec::RoboReader> {
pub fn open_reader(path: &std::path::Path) -> Result<RoboReader> {
let path_str = path
.to_str()
.ok_or_else(|| anyhow::anyhow!("Invalid UTF-8 path: {:?}", path))?;
Ok(robocodec::RoboReader::open(path_str)?)
Ok(RoboReader::open(path_str)?)
}
Loading