ADBDEV-6616: Fix potentially clobbered variables in PG_TRY/PG_CATCH blocks #43
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some local variables may have an undefined value after longjmp, which can lead to undefined behavior. This patch adds volatile to such variables based on a compiler warning. Fix a potential memory leak related to creating a hashmap inside a try/catch block. Add a compiler flag for throwing warnings related to clobbering variables.
KnightMurloc
force-pushed
the
ADBDEV-6616
branch
from
b11bbdb
to
a8f3c90
Compare
This comment was marked as resolved.
This comment was marked as resolved.
RekGRpth
reviewed
Nov 8, 2024
I'm not sure why this is necessary, but the compiler throws out a warning for these variables too. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Are you suggesting adding |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potentially clobbered variables in PG_TRY/PG_CATCH blocks
Some local variables may have an undefined value after longjmp, which can lead
to undefined behavior.
This patch adds volatile to such variables based on a compiler warning. Fix a
potential memory leak related to creating a hashmap inside a try/catch block.
Add a compiler flag for throwing error related to clobbering variables.