Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADBDEV-6616: Fix potentially clobbered variables in PG_TRY/PG_CATCH blocks #43

Open
wants to merge 2 commits into
base: gpdb
Choose a base branch
from
Open

ADBDEV-6616: Fix potentially clobbered variables in PG_TRY/PG_CATCH blocks #43

wants to merge 2 commits into from
+21 −21

Commits on Nov 7, 2024

  1. Fix potentially clobbered variables in PG_TRY/PG_CATCH blocks 

    Some local variables may have an undefined value after longjmp, which can lead
to undefined behavior.

This patch adds volatile to such variables based on a compiler warning.
Fix a potential memory leak related to creating a hashmap inside a try/catch
block.
Add a compiler flag for throwing warnings related to clobbering variables.
    @KnightMurloc
    KnightMurloc committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a8f3c90 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Treat clobbered warning as error

    @KnightMurloc
    KnightMurloc committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b718b72 View commit details
    Browse the repository at this point in the history