Remove 3.8 from status checks so #1202 can pass #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
the
type:skip-changelog
|
Checks will also be "expected" on this PR but it's less risk to first merge this |
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
force-pushed
the
remove-3.8-cicd
branch
from
f5cc8a7
to
51bb5d5
Compare
samj1912
reviewed
Sep 16, 2024
.github/workflows/cicd.yaml
Outdated
| @@ -16,7 +16,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-12] | |||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.9", "3.10", "3.11"] | |||
samj1912
reviewed
Sep 16, 2024
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
samj1912
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove 3.8 from the "required" cicd checks so that #1202 can pass