Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 3.8 from status checks so #1202 can pass #1203

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Remove 3.8 from status checks so #1202 can pass #1203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51bb5d5
Remove 3.8 from status checks so #1202 can pass
elliotgunton Sep 16, 2024
d3ee49f
Add python 3.12
sambhav Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cicd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-12]
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add 3.12 here?

sambhav marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.os }}

steps:
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
sambhav marked this conversation as resolved.
Show resolved Hide resolved

runs-on: ${{ matrix.os }}

Expand Down
Loading