Devtools 保存機能 #41
Open
Devtools 保存機能 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobkaz
force-pushed
the
devtools_recording
branch
4 times, most recently
from
49407b2 to
e68ef27
Compare
|
出力仕様など未定ですが、一旦この辺りでフロントエンドに詳しい人に見てもらいたいと思います @KOBA789 |
kobkaz
force-pushed
the
devtools_recording
branch
from
e68ef27 to
27be099
Compare
kobkaz
force-pushed
the
devtools_recording
branch
from
27be099 to
b4abc37
Compare
|
これ完全に私が止めちゃってますよねすみません。見ます。 |
|
kobkaz
force-pushed
the
devtools_recording
branch
from
b4abc37 to
bfe1baa
Compare
|
mainにリベース |
機能だけ実装したけれど、どうすれば見た目がまともになるかが全くわかりません |
|
このブランチに向かって UI の変更の PR 作ってみます。より良くなるかは自信ないですが…… |
kobkaz
force-pushed
the
devtools_recording
branch
from
b3ed474 to
9447f1c
Compare
Merged
kobkaz
force-pushed
the
devtools_recording
branch
3 times, most recently
from
b7dcfdb to
ee94baa
Compare
kobkaz
force-pushed
the
devtools_recording
branch
from
540db5f to
42b261f
Compare
kobkaz
force-pushed
the
devtools_recording
branch
from
aaff426 to
e8fb69b
Compare
|
blobについては当初と実装方針が変わったため、blob保存機能は一旦削除する |
|
これもうマージしてしまいたいので、UIだけ見てもらえますか @KOBA789 |
kobkaz
force-pushed
the
devtools_recording
branch
from
6b5cc35 to
7419fb2
Compare
KOBA789
reviewed
Apr 17, 2024
KOBA789
approved these changes
Apr 18, 2024
|
@kobkaz こちら、マージ作業進めちゃっていいですか？ |
|
いいと思います |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
保存内容の具体的なフォーマットは未定
テレメトリ名の横の〇マークをクリックで保存する/しないをトグル
sharedworker起動後初回の保存ではディレクトリ選択画面が開き、以降はそのディレクトリを基準として
${テレメトリ名}/${保存開始時間}.logに保存されるblobは
${テレメトリ名}/blob_data/${保存時間}.datに保存