fix: Standardize string representation to i8* and remove STRING_TYPE … #154

dev-m03 · 2026-01-14T21:58:32Z

Pull Request description

This PR standardizes the internal string representation to use i8* across
LLVM IR generation.

Previously, STRING_TYPE was defined as { i32, i8* }, but all string-related
operations (+, ==, puts, and casts) already operated directly on i8*.
This mismatch caused unnecessary complexity and inconsistent type handling.

The change removes STRING_TYPE and aligns string literals, casts, and
operations with the actual LLVM representation used throughout the codebase.

How to test these changes

Activate the development environment defined in conda/dev.yaml
Run CI-equivalent checks:
- makim tests.ci

Pull Request checklists

This PR is a:

maintenance

About this PR:

it includes tests.
the tests are executed on CI.
the tests generate log file(s) (path).
pre-commit hooks were executed locally.
this PR requires a project documentation update.

Author's checklist:

I have reviewed the changes and it contains no misspelling.
The code is well commented, especially in the parts that contain more complexity.
New and old tests passed locally.

Additional information

All existing string operations already relied on i8*; this change removes an
unused abstraction and reduces the likelihood of future type inconsistencies.

…rxlang#130)

dev-m03 · 2026-01-15T17:57:35Z

All tests and linters are passing.
The remaining Documentation / release job fails as expected on PRs due to semantic-release restrictions (no release permissions on pull requests).
Ready for review.

github-actions · 2026-01-15T17:59:43Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-15T18:07:47Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-15T18:15:42Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

yuvimittal · 2026-01-16T06:04:16Z

@dev-m03 , the CI/CD seems to fail, please look into it

github-actions · 2026-01-16T07:58:26Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T08:29:23Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T08:34:11Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

dev-m03 · 2026-01-16T08:39:30Z

@yuvimittal i am facing documentation/release(pull_request) test only failing one , trying to fix it and rerun the CI .
Thanks

github-actions · 2026-01-16T08:46:20Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T10:32:44Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T10:38:38Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T10:53:22Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/SUMMARY.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T10:58:22Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/SUMMARY.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T11:05:04Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/SUMMARY.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

dev-m03 · 2026-01-16T11:32:36Z

@yuvimittal trying my best but not able to fix the documentation/release(pull_request) test check fail .All other tests are passing , can you review and suggest changes? I think I will need assistance here .
Thanks a lot .

github-actions · 2026-01-16T11:47:29Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-16T12:04:28Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

github-actions · 2026-01-19T07:47:58Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/main.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

workflows/release.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

.makim.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

docs/index.md

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

mkdocs.yaml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

pyproject.toml

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

src/irx/builders/llvmliteir.py

ChatGPT was not able to review the file. Error: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

xmnlab · 2026-01-21T16:40:07Z

.github/workflows/docs.yaml

        run: |
          poetry config virtualenvs.create false
-          poetry install
+          poetry install --no-root


any reason for changing this file?

xmnlab

just added a few comments ... thanks for working on that.
ping us again when it is ready for a next round of review please.

xmnlab · 2026-01-21T16:40:18Z

.github/workflows/main.yaml

        run: |
          poetry check
-          poetry install
+          poetry install --no-root


any reason for changing this file?

its because it was causing CI build failures , so I added --no-root to prevent Poetry from installing the project itself, as IRX is dependency-driven and not meant to be installed as a package during tests.

xmnlab · 2026-01-21T16:40:26Z

.github/workflows/release.yaml


      - name: Install deps
-        run: poetry install
+        run: poetry install --no-root


any reason for changing this file?

same reason as previously told

xmnlab · 2026-01-21T16:40:40Z

.makim.yaml

-        run: pytest -vv --nbmake docs/tutorials
+        run: |
+          pip install -e .
+          pytest -vv --nbmake docs/tutorials


any reason for changing this file?

Installed the project in editable mode before running tests so tutorial notebooks can import the code correctly, so that CI failures can be tackled

xmnlab · 2026-01-21T16:40:59Z

.makim.yaml


      ci:
-        help: run the sames tests executed on CI
+        help: run the same tests executed on CI


good catch, thanks!

xmnlab · 2026-01-21T16:41:06Z

docs/index.md

@@ -1 +1,3 @@
-../README.md
+# IRx


any reason for changing this file?

yep that i will revert , i thought documentation test failure might be due to this and the edit was suggested by @omsherikar to fix it so i tried fixing the test failure

xmnlab · 2026-01-21T16:42:17Z

pyproject.toml


 [tool.ruff.lint]
 ignore = [
-  "F811",  # redefined-while-unused


you can keep these comments, so it is easy to know why these options are there.

sorry that was a mistake by my IDE, I will restore it

xmnlab · 2026-01-21T16:43:04Z

src/irx/builders/llvmliteir.py

-        )
        self._llvm.ASCII_STRING_TYPE = ir.IntType(8).as_pointer()
-        self._llvm.UTF8_STRING_TYPE = self._llvm.STRING_TYPE
+        self._llvm.UTF8_STRING_TYPE = self._llvm.ASCII_STRING_TYPE


utf8 is not plain ascii

github-actions · 2026-01-21T18:52:54Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

Potential breakage: you switched to poetry install --no-root and only export PYTHONPATH in the “Test tutorials” step. Each GitHub Actions step runs in a fresh shell, so docs.build won’t see that PYTHONPATH and may fail to import the project.

Suggested fix (choose one):

Add PYTHONPATH to the docs build step (preferred if you keep --no-root) (L.55):
env:
PYTHONPATH: ${{ github.workspace }}/src
Or revert to installing the project so imports/entry points exist (L.42):
poetry install

Also consider setting PYTHONPATH at the job level to avoid step-specific exports and reduce drift.

workflows/main.yaml

Material risk: poetry install --no-root won’t install your package into the venv. If you use a src/ layout or rely on your package’s console scripts/entry points, tests may fail or import from the wrong path.
Suggestion: revert to poetry install (L.83). If you keep --no-root for speed, ensure imports work:
- Add: echo "PYTHONPATH=src" >> $GITHUB_ENV before “Run tests” (e.g., insert a new step at L.85) and confirm tests don’t rely on installed entry points.

workflows/release.yaml

Potential release breakage: using poetry install --no-root means the project itself isn’t installed. If python-semantic-release (or any step) imports the package to resolve the version or entry points, this will fail at runtime. Either keep a full install on the publish path or validate by building before release. Suggestion (add after install) (L.36):
- name: Validate package builds
  run: poetry build
Hidden regressions: skipping root install means CI won’t catch packaging/install issues before publish. If you intend to speed up the test path only, gate the full install/build on actual release runs, e.g. keep --no-root for non-publish runs and do poetry install or poetry build when publishing (L.35).

.makim.yaml

LGTM!

docs/index.md

LGTM!

mkdocs.yaml

Security: The new pymdownx.snippets config disables path checks and allows includes from repository root. This can leak arbitrary files during docs build (e.g., CI secrets or unintended repo files) and makes PR previews risky. Recommend tightening:
- Set base_path to ["docs"] only
- Set restrict_base_path: true
- Set check_paths: true
  Example (L.117):
  pymdownx.snippets:
  base_path: [docs]
  restrict_base_path: true
  check_paths: true
Compatibility: The switch to material.extensions.emoji.* requires mkdocs-material v9+. Please pin mkdocs-material >= 9 in your requirements to avoid runtime errors on older environments (L.103).
Potential breaking behavior: Removing literate-nav means SUMMARY.md is no longer used to build navigation. If your nav previously depended on it, this will drop pages from the site. Confirm that all intended pages are now covered by the static nav or reintroduce the plugin (around L.60).

src/irx/builders/llvmliteir.py

High-risk ABI/behavior change: "string" now maps to i8* instead of the previous { i32, i8* } struct. Any existing codegen or runtime intrinsics expecting the struct will miscompile or fail IR verification. If this is an intentional migration, keep a deprecated alias to avoid breakage and ease rollout.

Suggestion (L.90):
STRING_TYPE: ir.types.Type # deprecated alias

Suggestion (L.212):
self._llvm.STRING_TYPE = self._llvm.ASCII_STRING_TYPE # deprecated alias for BC
Potential silent security/logic risk: switching to i8* assumes NUL-terminated buffers for uses like printf. Ensure all emitted string literals and any conversions produce NUL-terminated buffers, or guard call sites.

Suggestion (add helper near other builders utilities):
def ensure_cstring(self, val: ir.Value) -> ir.Value:
"""Ensure value is a NUL-terminated C-string pointer"""
return val # TODO: enforce/construct NUL-terminated global if not guaranteed
Cast visitor now only checks ASCII_STRING_TYPE. Since UTF8_STRING_TYPE is an alias to the same i8*, this is fine, but any remaining references to self._llvm.STRING_TYPE elsewhere will now break at runtime. Please grep and either remove or route them to the alias above.
Please verify all runtime function declarations/prototypes that previously used the struct string type are updated to i8*; mismatches will cause verifier errors or UB.

github-actions · 2026-01-21T18:53:15Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

Risk: Skipping root install breaks imports for docs.build. You set PYTHONPATH only for the tests step; the docs step won’t see the package. If docs use importlib.metadata.version or autodoc via distribution metadata, PYTHONPATH alone won’t be enough.

Suggested fixes:

Prefer restoring project install (L.43):
poetry install
Or ensure the docs step can import the package (L.51):
run: |
export PYTHONPATH=$PWD/src
makim --verbose docs.build

If docs rely on distribution metadata, you must install the project (L.43), not just set PYTHONPATH.

workflows/main.yaml

Using poetry install --no-root can hide packaging/installation regressions and break tests that import the installed package or rely on entry points. If speed is the goal, consider keeping this but add a separate packaging smoke-check step (e.g., poetry build && pip install dist/*.whl && python -c "import irx") to catch issues. Insert after the install step (L.82).
If you’re on Poetry >=1.2 with dependency groups, dev dependencies (pytest, makim, etc.) won’t be installed by default. Use poetry install --no-root --with dev to ensure test tooling is present (L.82). Otherwise this change may break the test run.

workflows/release.yaml

Possible functional regression: using --no-root means the project itself isn’t installed. If semantic-release (or any local plugins/hooks) import the package, this job will fail. Verify your semantic-release config doesn’t import project code. Otherwise, revert here or add a conditional install for publish runs.

Suggestion (L.37): run: poetry install
Or add before publish step:
- name: Install project for publish
  if: ${{ github.event_name == 'workflow_dispatch' }}
  run: poetry install

.makim.yaml

Using bare pip can invoke a different interpreter than the one running pytest. Replace with python -m pip and avoid re-resolving deps to reduce flakiness and latency (L.53):
python -m pip install -e . --no-deps
Installing during test execution mutates the environment and can hit the network, making the notebooks task non-hermetic and slower. Prefer moving the install to a pre-run hook of the notebooks task so the environment is prepared once (same block as L.53).

docs/index.md

LGTM!

mkdocs.yaml

Security: pymdownx.snippets now allows unrestricted includes and disables path checks. This can read arbitrary files from the build agent (path traversal via !include), risking secret leakage in CI. Recommend:
- Set restrict_base_path: true (L.120)
- Set check_paths: true (L.121)
- Consider removing '.' from base_path unless strictly required (L.119)
Compatibility: material.extensions.emoji.* requires mkdocs-material v9+. Ensure requirements are pinned accordingly; otherwise this will break the build. If you cannot bump yet, keep materialx.emoji.* (L.105–L.106).
Behavior: Removing literate-nav means SUMMARY.md is no longer parsed to build navigation. If any nav depended on it, the site nav will regress. Either ensure nav is fully generated elsewhere (e.g., gen_ref_nav.py) or retain the plugin/config (L.57–L.60).

pyproject.toml

Major: [tool.pytest.ini_options] pythonpath requires the pytest-pythonpath plugin. Without it, pytest will emit an unknown config option warning and ignore it, which can lead to import failures with a src/ layout unless the package is installed in editable mode. Recommend either adding pytest-pythonpath to dev/test deps or removing pythonpath and relying on an editable install in CI.
Minor: Switching readme to README.md assumes the file exists and is included in the sdist; if it’s missing at build time the build will fail and PyPI description will be empty. Double-check the file is present and rendered as Markdown by your backend.

src/irx/builders/llvmliteir.py

Breaking ABI/API: “string” now maps to i8* instead of the previous struct. Any code expecting length+ptr layout or referencing STRING_TYPE will break. Preserve the attribute and route “string” through it to allow internal representation changes without rippling API breaks.
- Add back the attribute in VariablesLLVM (L.90):
  def STRING_TYPE(self) -> ir.types.Type:
  """String LLVM type alias"""
- In initialize, alias it to ASCII (L.214):
  self._llvm.STRING_TYPE: ir.types.Type = self._llvm.ASCII_STRING_TYPE
- In get_data_type return the alias (L.133):
  elif type_name == "string":
  return self._llvm.STRING_TYPE
Correctness/safety: switching to raw i8* removes length metadata; any use with printf("%s") now relies on NUL-termination. Ensure all produced string pointers (especially from casts) are guaranteed NUL-terminated or you risk out-of-bounds reads. Consider adding a helper to enforce/construct a bounded, NUL-terminated buffer before emitting "%s" calls.
Future-proof the cast condition: it currently relies on UTF8_STRING_TYPE being the same object as ASCII. Make the intent explicit to avoid subtle regressions if these diverge later (L.2168):
elif target_type in (self._llvm.ASCII_STRING_TYPE, self._llvm.UTF8_STRING_TYPE):

github-actions · 2026-01-21T18:55:54Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

Using poetry install --no-root means the package itself isn’t installed. If your notebooks/docs rely on console_scripts, importlib.metadata/pkg_resources for version, or other package metadata, they can fail. Consider reverting to poetry install or explicitly installing the root package (L.43).
PYTHONPATH is only set for “Test tutorials”, not for “Generate documentation…”. If docs.build imports your package from src, it will break without the env var. Add the same export before makim docs.build or set PYTHONPATH at the job level env to cover both steps (L.55).
If docs are expected to reflect semantic-release changes via installed package metadata, not installing the root will prevent that. Either install the root after version bump or ensure docs build reads from source rather than distribution metadata (L.43, L.55).

workflows/main.yaml

Using poetry install --no-root can mask packaging/install issues and break tests that rely on installed package metadata, console scripts, or entry points. Consider adding a packaging check after deps install to catch this. Example (L.83):
- poetry build
- pip install --force-reinstall dist/*.whl
- Optional: run a quick smoke test of entry points
The test step should run inside Poetry’s venv; otherwise makim may execute outside the environment created by Poetry. Change (L.86):
- poetry run makim tests.unit

workflows/release.yaml

LGTM!

.makim.yaml

(L.50) Use the interpreter-qualified pip to avoid mismatches with pytest’s Python and reduce dependency churn: replace with
python -m pip install -e . --no-deps
This ensures the install targets the same interpreter running pytest and avoids unnecessary dependency resolution on every run.
(L.50) Running pip install on every notebooks task invocation mutates the environment and adds avoidable latency/flakiness. Consider moving the install into a pre-run hook executed once (or a separate setup task), and keep the notebooks task to only run pytest.

docs/index.md

LGTM!

mkdocs.yaml

Security: pymdownx.snippets is now effectively unrestricted. With restrict_base_path: false and base_path including ".", a malicious snippet in docs (e.g., from an untrusted PR) could include arbitrary files from the build host. Please restrict it to the docs directory only.
Suggested change (L.128):
pymdownx.snippets:
base_path: [docs]
restrict_base_path: true
check_paths: true
Compatibility: Switching emoji_index/generator to material.extensions.* requires mkdocs-material >= 9. If your env isn’t pinned, older versions will break at build time. Recommend pinning mkdocs-material >= 9 in your dependencies to avoid CI breakage.

src/irx/builders/llvmliteir.py

Missing method: LLVMLiteIRVisitor.translate() is called from LLVMLiteIR.build() but no longer defined, causing a runtime error. Add it back. (L.255)
def translate(self, node: astx.AST) -> str:
"""Translate ASTx into LLVM IR string."""
self.visit(node)
return str(self._llvm.module)
Undefined call: self._add_builtins() is invoked in LLVMLiteIRVisitor.init but the method is removed. Either reintroduce it or remove the call. If unused, remove the call. (L.104)
Uninitialized BOOLEAN_TYPE and missing mapping in get_data_type cause crashes in code using booleans. Initialize and map it. (L.118, L.63)

in initialize()

self._llvm.BOOLEAN_TYPE = ir.IntType(1)

in get_data_type()

elif type_name == "boolean":
return self.BOOLEAN_TYPE
Host size_t regression: SIZE_T_TYPE is hardcoded to i64 and POINTER_BITS is never set. Restore host-derived sizing to avoid 32-bit breakage. (L.124)

in initialize()

self._init_native_size_types()

or minimally:

self._llvm.SIZE_T_TYPE = ir.IntType(ctypes.sizeof(ctypes.c_size_t) * 8)
strlen_inline off-by-one: you increment before testing null, so length includes the terminator. Subtract 1 at return or move the increment into the non-null path. Minimal fix: (L.170)

at end block

n = b.load(idx)
b.ret(b.sub(n, ir.Constant(self._llvm.INT32_TYPE, 1)))
strcmp_inline logic bug: it never advances when chars are equal and not null, so only empty strings compare equal. Rework loop to continue on equal non-null, return true on first null-equal, false on first difference. (L.190-L.210)
def _create_strcmp_inline(self) -> ir.Function:
"""Create an inline strcmp function in LLVM IR."""
name = "strcmp_inline"
if name in self._llvm.module.globals:
return self._llvm.module.get_global(name)
fn = ir.Function(self._llvm.module,
ir.FunctionType(self._llvm.BOOLEAN_TYPE,
[self._llvm.STRING_PTR_TYPE, self._llvm.STRING_PTR_TYPE]),
name=name)
entry = fn.append_basic_block("entry")
loop = fn.append_basic_block("loop")
inc = fn.append_basic_block("inc")
eq = fn.append_basic_block("eq")
ne = fn.append_basic_block("ne")
b = ir.IRBuilder(entry)
idx = b.alloca(self._llvm.INT32_TYPE, name="i")
b.store(ir.Constant(self._llvm.INT32_TYPE, 0), idx)
b.branch(loop)
b.position_at_start(loop)
i = b.load(idx)
c1 = b.load(b.gep(fn.args[0], [i], inbounds=True))
c2 = b.load(b.gep(fn.args[1], [i], inbounds=True))
diff = b.icmp_signed("!=", c1, c2)
b.cbranch(diff, ne, inc)
b.position_at_start(inc)
is_null = b.icmp_signed("==", c1, ir.Constant(self._llvm.INT8_TYPE, 0))
b.cbranch(is_null, eq, loop)
b.position_at_start(ne)
b.ret(ir.Constant(self._llvm.BOOLEAN_TYPE, 0))
b.position_at_start(eq)
b.ret(ir.Constant(self._llvm.BOOLEAN_TYPE, 1))
Duplicate global for identical string literals: visit(LiteralUTF8String) uses a hash-based name without guarding redefinition. Reuse the existing global if present to avoid redefinition crashes. (L.210)
def visit(self, expr: astx.LiteralUTF8String) -> None:
"""Lower UTF-8 string literal to a global and return i8*."""
data = expr.value.encode("utf-8") + b"\0"
name = f"str_{abs(hash(expr.value))}"
if name in self._llvm.module.globals:
gv = self._llvm.module.get_global(name)
else:
arr_ty = ir.ArrayType(self._llvm.INT8_TYPE, len(data))
gv = ir.GlobalVariable(self._llvm.module, arr_ty, name=name)
gv.linkage = "internal"
gv.global_constant = True
gv.initializer = ir.Constant(arr_ty, data)
ptr = self._llvm.ir_builder.gep(
gv, [ir.Constant(self._llvm.INT32_TYPE, 0), ir.Constant(self._llvm.INT32_TYPE, 0)],
inbounds=True)
self.result_stack.append(ptr)

github-actions · 2026-01-21T18:57:21Z

OSL ChatGPT Reviewer

NOTE: This is generated by an AI program, so some comments may not make sense.

workflows/docs.yaml

Risk: Docs build may import the package (autodoc, version, etc.). With --no-root and no PYTHONPATH set in that step, it will fail to import. Add PYTHONPATH to the docs build step. (L.49)
Suggestion:
run: |
export PYTHONPATH=$PWD/src
makim --verbose docs.build
Risk: If tutorials/docs rely on package entry points or installed metadata, --no-root will break them. Either revert to installing the root package or ensure tests/docs don’t rely on entry points. (L.43)
Suggestion:
run: |
poetry config virtualenvs.create false
poetry install

workflows/main.yaml

Potential test breakage: Using poetry install --no-root means the project itself isn’t installed. If tests (or makim tasks) import the package, rely on entry points, or call importlib.metadata.version(...), they will fail. Consider reverting to poetry install (L.83).
If you want the speed win but still need imports, make the source importable explicitly before running tests:
- Insert after dependency install (before tests):
  (L.86)
  - name: Make package importable without install
    run: echo "PYTHONPATH=${{ github.workspace }}/src" >> $GITHUB_ENV
    Adjust src to . if you don’t use a src/ layout.

workflows/release.yaml

Potential breaking change: using poetry install --no-root means the project itself won’t be installed into the venv. If any later step imports the package, uses its console scripts/entry points, or if semantic-release reads version by importing the package, this will fail. Please confirm semantic-release reads version from pyproject or a file path, not via import. Otherwise, keep poetry install or add a conditional install of the root package. (L.36)
Suggestion: add a follow-up step only when needed by subsequent steps:
- name: Install project package (only if required)
  run: pip install -e . # or remove --no-root from poetry install
  (L.36)

.makim.yaml

Using bare pip can target a different interpreter than the one running pytest, leading to nondeterministic installs/imports. Replace with python -m pip to ensure the same env is used (L.54).
- Suggested change:
  - python -m pip install -e .

docs/index.md

LGTM!

mkdocs.yaml

Compatibility risk: The switch to material.extensions.emoji.* requires mkdocs-material >= 9.0. Builds with older versions will fail to import the emoji helpers (L.106-L.107). Please pin mkdocs-material>=9 in your docs dependencies, or revert to materialx.emoji.*.
Security/maintainability: Disabling restrict_base_path and check_paths for pymdownx.snippets allows including files from anywhere under the repo (and potentially outside if absolute paths are used) and can hide broken includes. It also increases the watch/build surface and can slow local dev. Recommend:
- restrict_base_path: true (L.123)
- check_paths: true (L.124)
- Consider narrowing base_path to only docs if feasible: base_path: [docs] (L.122)
Behavior change: Removing literate-nav may break SUMMARY.md-driven navigation if any pages relied on it. Ensure there are no orphaned pages or broken links after this change.

src/irx/builders/llvmliteir.py

Missing method: LLVMLiteIRVisitor.translate() was removed but LLVMLiteIR.build() still calls it, causing AttributeError at runtime. Reintroduce translate on the visitor (L.95):
def translate(self, node: astx.AST) -> str:
"""Translate AST to LLVM IR text."""
self.visit(node)
return str(self._llvm.module)
init calls self._add_builtins() but the method is removed, causing AttributeError (L.106). Either drop the call or re-add a stub that does nothing:
def _add_builtins(self) -> None:
"""Initialize built-in functions."""
return
BOOLEAN_TYPE is used but never initialized, leading to attribute errors when creating functions returning i1 (e.g., strcmp) (L.122). Initialize it during setup:
self._llvm.BOOLEAN_TYPE = ir.IntType(1)
get_data_type() lacks mapping for boolean, which will break when a boolean type is requested (L.66). Add:
elif type_name in ("boolean", "bool"):
return self.BOOLEAN_TYPE
Platform-size types: forcing SIZE_T_TYPE to i64 is incorrect on 32-bit hosts and breaks malloc/snprintf signatures (L.141). Restore native sizing:
self._llvm.POINTER_BITS = ctypes.sizeof(ctypes.c_void_p) * 8
self._llvm.SIZE_T_TYPE = ir.IntType(ctypes.sizeof(ctypes.c_size_t) * 8)
strlen_inline off-by-one: you increment the counter before checking for NUL, returning length+1 (L.160). Only increment when not NUL:
def _create_strlen_inline(self) -> ir.Function:
"""Inline strlen."""
...
b.position_at_start(loop)
i = b.load(idx)
ch_ptr = b.gep(fn.args[0], [i], inbounds=True)
ch = b.load(ch_ptr)
is_null = b.icmp_signed("==", ch, ir.Constant(self._llvm.INT8_TYPE, 0))
with b.if_then(is_null):
b.ret(i)
next_i = b.add(i, ir.Constant(self._llvm.INT32_TYPE, 1))
b.store(next_i, idx)
b.branch(loop)
strcmp_inline logic is incorrect: it never advances on equal non-NUL chars and returns false prematurely (L.182). Use the standard loop:
def _create_strcmp_inline(self) -> ir.Function:
"""Inline strcmp returning i1 (equal)."""
...
b.position_at_start(loop)
i = b.load(idx)
c1 = b.load(b.gep(fn.args[0], [i], inbounds=True))
c2 = b.load(b.gep(fn.args[1], [i], inbounds=True))
neq = b.icmp_signed("!=", c1, c2)
with b.if_then(neq):
b.ret(ir.Constant(self._llvm.BOOLEAN_TYPE, 0))
is_null = b.icmp_signed("==", c1, ir.Constant(self._llvm.INT8_TYPE, 0))
with b.if_then(is_null):
b.ret(ir.Constant(self._llvm.BOOLEAN_TYPE, 1))
next_i = b.add(i, ir.Constant(self._llvm.INT32_TYPE, 1))
b.store(next_i, idx)
b.branch(loop)

yuvimittal · 2026-01-22T15:14:34Z

@dev-m03 , why delete the llvmliteir ?

dev-m03 closed this Jan 15, 2026

dev-m03 reopened this Jan 15, 2026

dev-m03 added 3 commits January 15, 2026 22:34

fix: Standardize string representation to i8* and remove STRING_TYPE (a…

febb0f3

…rxlang#130)

chore: trigger CI rerun

9033753

chore: ci rerun check

d21e17a

dev-m03 force-pushed the fix/string-i8-pointer branch from 73b6961 to d21e17a Compare January 15, 2026 17:07

dev-m03 added 3 commits January 15, 2026 22:51

ci rerun trigger

4d951f5

ci: fix makim yaml indentation and set PYTHONPATH for tests

53647bc

fix: correct readme path for Poetry packaging

005bb75

dev-m03 marked this pull request as ready for review January 15, 2026 17:58

ci: set PYTHONPATH for tests and notebooks with no-root install

1e44cf2

fix: pass PYTHONPATH to nbmake kernel for notebook tests

32b0df1

fix: configure pytest pythonpath for notebook execution

ef53542

docs: add missing mkdocs index page

995f9d4

new fixes

82104ec

fixing docu tests

c0d866d

docs: fix mkdocs paths for CI working directory

ad42446

docs: fix mkdocs paths for CI working directory

5128c7a

dev-m03 reopened this Jan 16, 2026

fixing test runs

450e392

fixing test runs

c73d364

dev-m03 marked this pull request as draft January 16, 2026 11:05

dev-m03 added 3 commits January 16, 2026 16:42

fixing test runs

4d9ec09

fixing test runs

8f279ec

fixing test runs

e5292eb

fixing test runs

ab4c80b

dev-m03 marked this pull request as ready for review January 16, 2026 11:46

Add index.md for documentation homepage

7d51aba

xmnlab reviewed Jan 21, 2026

View reviewed changes

dev-m03 added 4 commits January 22, 2026 00:16

fixing docs

557f64a

Update readme path and adjust linting settings

edb9bea

Update print statement from 'Hello' to 'Goodbye'

aa3f396

restoring file

6b97ae0

dev-m03 marked this pull request as draft January 21, 2026 18:52

Merge branch 'main' into fix/string-i8-pointer

d929fce

		@@ -1 +1,3 @@
		../README.md No newline at end of file
		# IRx

fix: Standardize string representation to i8* and remove STRING_TYPE … #154

Are you sure you want to change the base?

fix: Standardize string representation to i8* and remove STRING_TYPE … #154

Uh oh!

Conversation

dev-m03 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request description

How to test these changes

Pull Request checklists

Additional information

Uh oh!

dev-m03 commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

OSL ChatGPT Reviewer

workflows/docs.yaml

workflows/main.yaml

workflows/release.yaml

.makim.yaml

docs/index.md

pyproject.toml

src/irx/builders/llvmliteir.py

Uh oh!

github-actions bot commented Jan 15, 2026

OSL ChatGPT Reviewer

workflows/docs.yaml

workflows/main.yaml

workflows/release.yaml

.makim.yaml

docs/index.md

pyproject.toml

src/irx/builders/llvmliteir.py

Uh oh!

github-actions bot commented Jan 15, 2026

OSL ChatGPT Reviewer

workflows/docs.yaml

workflows/main.yaml

workflows/release.yaml

.makim.yaml

docs/index.md

pyproject.toml

src/irx/builders/llvmliteir.py

Uh oh!

yuvimittal commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

OSL ChatGPT Reviewer

workflows/docs.yaml

workflows/main.yaml

workflows/release.yaml

.makim.yaml

docs/index.md

pyproject.toml

src/irx/builders/llvmliteir.py

Uh oh!

github-actions bot commented Jan 16, 2026

OSL ChatGPT Reviewer

workflows/docs.yaml

workflows/main.yaml

workflows/release.yaml

.makim.yaml

docs/index.md

pyproject.toml

src/irx/builders/llvmliteir.py

Uh oh!

github-actions bot commented Jan 16, 2026

OSL ChatGPT Reviewer

workflows/docs.yaml

workflows/main.yaml

workflows/release.yaml

.makim.yaml

docs/index.md

pyproject.toml

src/irx/builders/llvmliteir.py

Uh oh!

dev-m03 commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

OSL ChatGPT Reviewer

dev-m03 commented Jan 14, 2026 •

edited

Loading