-
Notifications
You must be signed in to change notification settings - Fork 13
fix: Standardize string representation to i8* and remove STRING_TYPE … #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
febb0f3
9033753
d21e17a
4d951f5
53647bc
005bb75
1e44cf2
32b0df1
ef53542
995f9d4
82104ec
c0d866d
ad42446
5128c7a
dc03d2c
450e392
c73d364
4d9ec09
8f279ec
e5292eb
ab4c80b
7d51aba
557f64a
edb9bea
aa3f396
6b97ae0
d929fce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,7 @@ jobs: | |
| - name: Install dependencies | ||
| run: | | ||
| poetry check | ||
| poetry install | ||
| poetry install --no-root | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any reason for changing this file?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its because it was causing CI build failures , so I added --no-root to prevent Poetry from installing the project itself, as IRX is dependency-driven and not meant to be installed as a package during tests. |
||
|
|
||
| - name: Run tests | ||
| run: makim tests.unit | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ jobs: | |
| python-version: "3.9" | ||
|
|
||
| - name: Install deps | ||
| run: poetry install | ||
| run: poetry install --no-root | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any reason for changing this file?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same reason as previously told |
||
|
|
||
| - name: Run semantic release (for tests) | ||
| if: ${{ github.event_name != 'workflow_dispatch' }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,10 +47,12 @@ groups: | |
|
|
||
| notebooks: | ||
| help: test jupyter notebooks | ||
| run: pytest -vv --nbmake docs/tutorials | ||
| run: | | ||
| pip install -e . | ||
| pytest -vv --nbmake docs/tutorials | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any reason for changing this file?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Installed the project in editable mode before running tests so tutorial notebooks can import the code correctly, so that CI failures can be tackled |
||
|
|
||
| ci: | ||
| help: run the sames tests executed on CI | ||
| help: run the same tests executed on CI | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch, thanks! |
||
| hooks: | ||
| pre-run: | ||
| - task: tests.unit | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| ../README.md | ||
| ../README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for changing this file?