Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated PublicKeyCredentialSourceRepository and refactor all signature methods #441

Merged
merged 7 commits into from
Sep 4, 2023

Conversation

asbiin
Copy link
Owner

@asbiin asbiin commented Sep 4, 2023

BREAKING CHANGE: CredentialRepository no longer implements PublicKeyCredentialSourceRepository.
BREAKING CHANGE: All method signatures are now well defined, the doc-block type-hint have been deleted. This should not impact you as it's backward compatible.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 33f4a2b into main Sep 4, 2023
15 checks passed
@asbiin asbiin deleted the 20230904-refactor branch September 4, 2023 19:20
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants