Skip to content

Conversation

@vlkv
Copy link

@vlkv vlkv commented Nov 7, 2025

What I have changed:

  • added flags to .bazelrc to enable linting aspects at every bazel build + flag to fail the build on errors from linters
  • added bazelisk to the root of //example
  • added gcc_toolchain because I do not have gcc installed on my host machine

How to run:

cd ./example
./bazelisk build //src:ts

Actual result NO ERRORS from eslint:

INFO: Invocation ID: 7767b568-08fd-4077-833d-a7ca686b0525
WARNING: Build option --@@aspect_rules_ts~//ts:skipLibCheck has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed).
Analyzing: target //src:ts (0 packages loaded, 0 targets configured)
INFO: Analyzed target //src:ts (0 packages loaded, 21464 targets configured).
INFO: Found 1 target...
Target //src:ts up-to-date:
  bazel-bin/src/file.js
Aspect //tools/lint:linters.bzl%eslint of //src:ts up-to-date (nothing to build)
INFO: Elapsed time: 0.751s, Critical Path: 0.13s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Expected result: there SHOULD BE SOME ERRORS from eslint! Because they present in the example/src/file.ts

@aspect-workflows
Copy link

aspect-workflows bot commented Nov 7, 2025

Test

All tests were cache hits

5 tests (100.0%) were fully cached saving 2s.


Test

example

Waiting for runner...


Test (WORKSPACE) (Test)

example

Buildkite build #470 is running...


Lint

example

0 issues require fixes
0 issues can be fixed automatically


Lint [.]

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vitaly Volkov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants