build: ensure dotnet build and dotnet pack works - including resource…

…s assemblies
atc-net · Feb 6, 2025 · d754e96 · d754e96
1 parent 9ad6d8a
commit d754e96
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 1 deletion.
diff --git a/.github/workflows/post-integration.yml b/.github/workflows/post-integration.yml
@@ -50,6 +50,9 @@ jobs:
       - name: 🛠️ Build
         run: dotnet build -c Release --no-restore /p:UseSourceLink=true
 
+      - name: 🛠️ Build netstandard2.1
+        run: dotnet build -c Release --no-restore /p:UseSourceLink=true -f netstandard2.1 src/Atc/Atc.csproj
+
       - name: 🧪 Run unit tests
         run: dotnet test -c Release --no-build --filter "Category!=Integration"
 

diff --git a/.github/workflows/pre-integration.yml b/.github/workflows/pre-integration.yml
@@ -33,6 +33,9 @@ jobs:
       - name: 🛠️ Building library in release mode
         run: dotnet build -c Release --no-restore
 
+      - name: 🛠️ Building library in release mode for netstandard2.1
+        run: dotnet build -c Release --no-restore -f netstandard2.1 src/Atc/Atc.csproj
+
   dotnet-test:
     runs-on: ubuntu-latest
     needs:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -41,6 +41,9 @@ jobs:
       - name: 🛠️ Building library in release mode
         run: dotnet build -c Release --no-restore /p:UseSourceLink=true
 
+      - name: 🛠️ Building library in release mode for netstandard2.1
+        run: dotnet build -c Release --no-restore -f netstandard2.1 src/Atc/Atc.csproj
+
       - name: ⏩ Merge to release-branch
         run: |
           git config --local user.email ${{ env.ATC_EMAIL }}

diff --git a/src/Atc/Atc.csproj b/src/Atc/Atc.csproj
@@ -5,6 +5,7 @@
     <PackageId>Atc</PackageId>
     <PackageTags>netstandard;common</PackageTags>
     <Description>Atc is a collection of classes and extension methods for common functionality.</Description>
+    <GenerateSatelliteAssemblies>true</GenerateSatelliteAssemblies>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Atc/Extensions/StringExtensions.cs b/src/Atc/Extensions/StringExtensions.cs
@@ -13,6 +13,8 @@ namespace System;
 /// <summary>
 /// Extensions for the string class.
 /// </summary>
+[SuppressMessage("Spacing Rules", "SA1028:Code should not contain trailing whitespace", Justification = "OK - #if")]
+[SuppressMessage("Documentation Rules", "SA1625:Element documentation should not be copied and pasted", Justification = "OK - #if")]
 public static class StringExtensions
 {
     /// <summary>

diff --git a/test/Atc.Tests/Atc.Tests.csproj b/test/Atc.Tests/Atc.Tests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0;netstandard2.1</TargetFrameworks>
+    <TargetFramework>net8.0</TargetFramework>
     <IsPackable>false</IsPackable>
   </PropertyGroup>