This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
I made a mistake in atom#177. For whatever reason, I wrote a quick patch in my browser, and obviously, this code would never yield anything useful, _because it is just silly javascript_. The discussion in atom#185 made me verify my patch. This new patch should actually do something, while I have to admit that I've only verified it via Chrome's console. My test below seems valid enough. ```js const markdownGrammars = ['source.gfm', 'text.md'] let grammarScopeName = 'text.md' markdownGrammars.includes(grammarScopeName) // true grammarScopeName = 'source.js' markdownGrammars.includes(grammarScopeName) // false ```
1 task
|
Thanks for revisiting this @burodepeper! Would you be able to add a test for this? The team needs tests in general before they can take a look but also to help make sure future changes in the package don't end up breaking your fix 😄 |
Contributor
Author
|
Sure! I’ll have a look at it after my Christmas break.
…On Fri, 21 Dec 2018 at 03:22, Robert Sese ***@***.***> wrote:
Thanks for revisiting this @burodepeper <https://github.com/burodepeper>!
Would you be able to add a test for this? The team needs tests in general
before they can take a look but also to help make sure future changes in
the package don't end up breaking your fix 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#186 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADiC6i5pABLgYAZuXW3uGcAnHLBOb7tEks5u7EXcgaJpZM4Za8bU>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
I made a mistake in #177.
For whatever reason, I wrote a quick patch in my browser, and obviously, this code would never yield anything useful, because it is just silly javascript. The discussion in #185 made me verify my patch. This new patch should actually do something, while I have to admit that I've only verified it via Chrome's console. My test below seems valid enough.
Alternate Designs
Not applicable
Benefits
Not applicable
Possible Drawbacks
Not fully tested from within Atom. This patch wouldn't break anything any further, at least...
Applicable Issues
Not applicable