Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localization #6

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Added localization #6

merged 1 commit into from
Jun 23, 2024

Conversation

humdingerb
Copy link
Contributor

Still missing: generating the en.catkeys

Still missing: generating the en.catkeys
@humdingerb
Copy link
Contributor Author

I don't know how to generate the en.catkeys with the cmake buildsystem. Or how to add the translated catkeys, come to think of it...

@humdingerb humdingerb mentioned this pull request Jun 16, 2024
Comment on lines -240 to +249
.AddMenu("Preferences & Help")
.AddMenu(B_TRANSLATE("Settings & Help"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still debating this one. There are still quite a few apps that refer to it as "Preferences". Tracker & Deskbar for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, sorry I missed pointing out this change.

IMO, and I think at least Haiku apps generally adhere to that, "Preferences" are the applets found in Deskbar's "Preferences" menu, or are system component preferences like for Tracker and Deskbar.
"Application-internal" preferences are "Settings".

Things become difficult when it comes to "Options". :)
Those are best avoided, but maybe those would be options that refer to the current document or view, and are separate from the "app-internal" Settings. At least that's my current thinking...

@augiedoggie
Copy link
Owner

I don't know how to generate the en.catkeys with the cmake buildsystem. Or how to add the translated catkeys, come to think of it...

It has to be enabled in the cmake files. You can see an example in the Beezer build files. Then the build could be configured with cmake -DHAIKU_ENABLE_I18N=ON or that variable could be permanently set to ON in the cmake files.

I can take care of it later. That part of the build system doesn't get much use so there may be some other steps required.

@humdingerb
Copy link
Contributor Author

Appreciated. 👍

@augiedoggie augiedoggie merged commit 6475520 into augiedoggie:main Jun 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants