refactor(autoware_map_msgs): modify pcd metadata msg #7852

YamatoAndo · 2024-07-04T10:58:42Z

Description

I have modified the code to reflect the changes in autoware_map_msgs.

How was this PR tested?

build with autowarefoundation/autoware_msgs#96
Lsim works

Notes for reviewers

The build tests will not pass unless autowarefoundation/autoware_msgs#96 is merged first.

Interface changes

None.

Effects on system behavior

None.

…etaData Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

github-actions · 2024-07-04T10:59:01Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

…_msgs/modify_metadata_msg

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

yukkysaito · 2024-07-10T12:32:26Z

@YamatoAndo Could you also check to work with psim?

SakodaShintaro

I have also confirmed that logging_simulator works properly with data that uses divided pcds.
(psim also works)
Looks Good To Me

YamatoAndo · 2024-07-17T10:07:30Z

compare_map_segmentation's codeowners (@amc-nu @yukkysaito @badai-nguyen)
elevation_map_loader's codeowners (@kosuke55 @Shin-kyoto)
Please review 🙇

badai-nguyen

LGTM regarding compare_map_segmentation.

I confirmed that compare_map_segmentation worked with split map pointcloud in Dynamic Map Loader. The result looks reasonable.

[component_container_mt-1] [INFO] [1721226488.044111808] [perception.object_recognition.detection.voxel_based_compare_map_filter]: VoxelGridDynamicMapLoader initialized.

white pc: obstacle_segmentation
pink: compare_map_segmentation

yukkysaito

LGTM

…_msgs/modify_metadata_msg

codecov · 2024-07-24T09:26:58Z

Codecov Report

Attention: Patch coverage is 47.94521% with 38 lines in your changes missing coverage. Please review.

Project coverage is 29.11%. Comparing base (f33635c) to head (227eaee).
Report is 4 commits behind head on main.

Files	Patch %	Lines
...intcloud_map_loader/selected_map_loader_module.cpp	0.00%	17 Missing ⚠️
...ation_map_loader/src/elevation_map_loader_node.cpp	0.00%	5 Missing ⚠️
map/map_height_fitter/src/map_height_fitter.cpp	0.00%	4 Missing ⚠️
...oader/test/test_differential_map_loader_module.cpp	0.00%	0 Missing and 2 partials ⚠️
...map_loader/test/test_partial_map_loader_module.cpp	0.00%	0 Missing and 2 partials ⚠️
...ion/src/distance_based_compare_map_filter/node.hpp	0.00%	2 Missing ⚠️
...c/voxel_distance_based_compare_map_filter/node.hpp	0.00%	2 Missing ⚠️
...rc/voxel_grid_map_loader/voxel_grid_map_loader.cpp	0.00%	2 Missing ⚠️
...rc/voxel_grid_map_loader/voxel_grid_map_loader.hpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7852      +/-   ##
==========================================
- Coverage   29.13%   29.11%   -0.02%     
==========================================
  Files        1607     1612       +5     
  Lines      118180   118231      +51     
  Branches    50849    50853       +4     
==========================================
  Hits        34427    34427              
- Misses      74534    74585      +51     
  Partials     9219     9219

Flag	Coverage Δ		*Carryforward flag
differential	`8.14% <47.94%> (?)`
total	`29.11% <ø> (-0.02%)`	⬇️	Carriedforward from f33635c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…efoundation#7852)" This reverts commit 8ea7de7.

…efoundation#7852)" This reverts commit 8ea7de7. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

…7852)" (#8180) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

…ion#7852) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@tier4.jp>

…ion#7852) Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

…utowarefoundation#7852)" (autowarefoundation#8180) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

xmfcx · 2024-07-29T12:53:27Z

This was reverted by:

revert: revert "refactor(autoware_map_msgs): modify pcd metadata msg (#7852)" #8180

…ion#7852) Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

…utowarefoundation#7852)" (autowarefoundation#8180) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

YamatoAndo added 2 commits July 4, 2024 18:46

delete PointCloudMapCellMetaDataWithID, add cell_id to PointCloudMapM…

3b27ad6

…etaData Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

rename msg

7cbe76e

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

pre-commit-ci bot and others added 5 commits July 4, 2024 11:00

style(pre-commit): autofix

4365769

rename

9353bc6

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

Merge remote-tracking branch 'origin/main' into refactor/autoware_map…

7658df8

…_msgs/modify_metadata_msg

fix const

aa70ae0

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

fix [[nodiscard]]

71b27d1

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

YamatoAndo force-pushed the refactor/autoware_map_msgs/modify_metadata_msg branch from d0914d7 to 71b27d1 Compare July 10, 2024 08:34

style(pre-commit): autofix

63e00de

YamatoAndo marked this pull request as ready for review July 10, 2024 08:43

YamatoAndo requested review from kosuke55, Shin-kyoto, amc-nu, badai-nguyen, yukkysaito, anhnv3991, KYabuuchi, kminoda, Motsu-san, RyuYamamoto, SakodaShintaro, TaikiYamada4 and isamu-takagi as code owners July 10, 2024 08:43

SakodaShintaro approved these changes Jul 11, 2024

View reviewed changes

SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 11, 2024

badai-nguyen approved these changes Jul 17, 2024

View reviewed changes

yukkysaito approved these changes Jul 18, 2024

View reviewed changes

kosuke55 approved these changes Jul 22, 2024

View reviewed changes

YamatoAndo enabled auto-merge (squash) July 22, 2024 09:22

Merge branch 'main' into refactor/autoware_map_msgs/modify_metadata_msg

c51df4a

YamatoAndo disabled auto-merge July 22, 2024 10:34

YamatoAndo enabled auto-merge (squash) July 22, 2024 10:57

kminoda removed their request for review July 23, 2024 01:59

YamatoAndo disabled auto-merge July 24, 2024 04:15

Merge remote-tracking branch 'origin/main' into refactor/autoware_map…

227eaee

…_msgs/modify_metadata_msg

YamatoAndo enabled auto-merge (squash) July 24, 2024 08:41

mitsudome-r added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 24, 2024

mitsudome-r disabled auto-merge July 24, 2024 10:04

mitsudome-r merged commit 8ea7de7 into autowarefoundation:main Jul 24, 2024
39 of 42 checks passed

mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this pull request Jul 25, 2024

Revert "refactor(autoware_map_msgs): modify pcd metadata msg (autowar…

7ee0293

…efoundation#7852)" This reverts commit 8ea7de7.

mitsudome-r added a commit that referenced this pull request Jul 25, 2024

revert: revert "refactor(autoware_map_msgs): modify pcd metadata msg (#…

563faec

…7852)" (#8180) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

mitsudome-r mentioned this pull request Jul 25, 2024

refactor(autoware_map_msgs): modify pcd metadata msg (#7852) #8182

Open

chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024

refactor(autoware_map_msgs): modify pcd metadata msg (autowarefoundat…

97df906

…ion#7852) Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024

refactor(autoware_map_msgs): modify pcd metadata msg (autowarefoundat…

1070a32

…ion#7852) Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(autoware_map_msgs): modify pcd metadata msg #7852

refactor(autoware_map_msgs): modify pcd metadata msg #7852

YamatoAndo commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading

yukkysaito commented Jul 10, 2024

SakodaShintaro left a comment •

edited

Loading

YamatoAndo commented Jul 17, 2024

badai-nguyen left a comment

yukkysaito left a comment

codecov bot commented Jul 24, 2024 •

edited

Loading

xmfcx commented Jul 29, 2024 •

edited

Loading

refactor(autoware_map_msgs): modify pcd metadata msg #7852

refactor(autoware_map_msgs): modify pcd metadata msg #7852

Conversation

YamatoAndo commented Jul 4, 2024 • edited Loading

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Jul 4, 2024 • edited Loading

yukkysaito commented Jul 10, 2024

SakodaShintaro left a comment • edited Loading

Choose a reason for hiding this comment

YamatoAndo commented Jul 17, 2024

badai-nguyen left a comment

Choose a reason for hiding this comment

yukkysaito left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 24, 2024 • edited Loading

Codecov Report

xmfcx commented Jul 29, 2024 • edited Loading

YamatoAndo commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading

SakodaShintaro left a comment •

edited

Loading

codecov bot commented Jul 24, 2024 •

edited

Loading

xmfcx commented Jul 29, 2024 •

edited

Loading