Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): override setInitState #9340

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Nov 15, 2024

Description

Currently the static obstacle avoidance module with transit from IDLE to RUNNING for it's initial state transition. Ideally the module should check safety before it executes the avoidance maneuver. Thus the initial state transition is modified to IDLE to WAITING_FOR_APPROVAL in this PR.

Related links

None

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@go-sakayori go-sakayori added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.82%. Comparing base (8028e38) to head (0f1233e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_static_obstacle_avoidance_module/scene.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9340      +/-   ##
==========================================
- Coverage   29.82%   29.82%   -0.01%     
==========================================
  Files        1338     1339       +1     
  Lines      103205   103221      +16     
  Branches    40213    40213              
==========================================
+ Hits        30778    30781       +3     
- Misses      69442    69457      +15     
+ Partials     2985     2983       -2     
Flag Coverage Δ *Carryforward flag
differential 21.49% <0.00%> (?)
total 29.82% <ø> (ø) Carriedforward from 8028e38

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori merged commit 1ed46dc into autowarefoundation:main Nov 15, 2024
44 checks passed
@go-sakayori go-sakayori deleted the fix/soa_init_state branch November 15, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants