Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): change vls driver to nebula driver #3699

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

drwnz
Copy link
Contributor

@drwnz drwnz commented Jul 31, 2023

Description

This PR should be tested in conjunction with autowarefoundation/sample_sensor_kit_launch#64
This PR changes the LiDAR driver used from velodyne_vls to Nebula.
Nebula is actively maintained, supports more different LiDARs, and has been tested to have feature parity with velodyne_vls for Velodyne VLP16 and Velodyne VLS128.

Tests performed

This has been tested with the Autoware sample_sensor_kit_launch on branch feat/nebula and the sample Autoware map and rosbag data found here:
https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/rosbag-replay-simulation/

Localization, pointcloud preprocessing, and perception were all found to work with the same performance as with the previous velodyne_vls driver.

Effects on system behavior

System behavior should be the same as when using the previous velodyne_vls LiDAR driver, with some performance benefits (and more to come as Nebula is developed and optimized).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: David Wong <david.wong@tier4.jp>
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz added type:new-feature New functionalities or additions, feature requests. component:sensing Data acquisition from sensors, drivers, preprocessing. labels Jul 31, 2023
@mitsudome-r mitsudome-r merged commit 1fce19b into autowarefoundation:main Aug 2, 2023
24 checks passed
@drwnz drwnz deleted the feat/nebula branch August 2, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants