feat(ux): update get ready page with new preview screen #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaland
reviewed
Nov 28, 2023
| import VideoToolbox | ||
|
|
||
| extension CGImage { | ||
| static func convert(from cvPixelBuffer: CVPixelBuffer?) -> CGImage? { |
There was a problem hiding this comment.
nit: Indentation seems to be 2 spaces instead of 4 in this file.
There was a problem hiding this comment.
fixed indentation
| .resizable() | ||
| .scaledToFill() | ||
| .frame( | ||
| width: geometry.size.width, |
There was a problem hiding this comment.
fixed identation
|
|
||
| @StateObject var model: CameraPreviewViewModel | ||
|
|
||
| public init(model: CameraPreviewViewModel = CameraPreviewViewModel()) { |
There was a problem hiding this comment.
removed public access modifier
| super.init() | ||
| setupSubscriptions() | ||
|
|
||
| let avCpatureDevice = AVCaptureDevice.DiscoverySession( |
sebaland
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check points: (check or cross out if not relevant)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.