-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ux): update get ready page with new preview screen #78
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e79ae85
add preview/hair check screen
phantumcode 5c05555
Merge branch 'main' into feat/ux_updates
phantumcode e3cab2c
chore(ux): add error log message
phantumcode fec3833
chore(ux): update handling of camera permissions
phantumcode a63fa01
chore: reset integration test
phantumcode cbab9db
fix build error
phantumcode 33bff1a
fix build error
phantumcode 8220c13
chore: misc ux updates
phantumcode 3de4915
chore: update sample and integration app results screen
phantumcode ea75f06
chore: update UX
phantumcode 581f97c
chore: minor UX tweak on oval dimension
phantumcode fe51273
chore: remove camera permission title
phantumcode 0ba4247
chore: update UX
phantumcode e9276fb
chore: update per review feedback
phantumcode dccc86b
chore: update localization strings
phantumcode 639464a
update readme
phantumcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 0 additions & 21 deletions
21
.../FaceLiveness/Resources/Assets.xcassets/illustration_face_good_fit.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-3.65 KB
...ets.xcassets/illustration_face_good_fit.imageset/illustration_face_good_fit.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
...FaceLiveness/Resources/Assets.xcassets/illustration_face_too_close.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-2.38 KB
...s.xcassets/illustration_face_too_close.imageset/illustration_face_too_close.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
...s/FaceLiveness/Resources/Assets.xcassets/illustration_face_too_far.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-6 KB
...ssets.xcassets/illustration_face_too_far.imageset/illustration_face_too_far.png
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// | ||
// Copyright Amazon.com Inc. or its affiliates. | ||
// All Rights Reserved. | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
|
||
import CoreGraphics | ||
import VideoToolbox | ||
|
||
extension CGImage { | ||
static func convert(from cvPixelBuffer: CVPixelBuffer?) -> CGImage? { | ||
guard let pixelBuffer = cvPixelBuffer else { | ||
return nil | ||
} | ||
|
||
var image: CGImage? | ||
VTCreateCGImageFromCVPixelBuffer( | ||
pixelBuffer, | ||
options: nil, | ||
imageOut: &image) | ||
return image | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Indentation seems to be 2 spaces instead of 4 in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed indentation