-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating to dynatrace-operator 1.3.0 and adding test job #298
Conversation
Looks like your deployment
Looks like your deployment
Looks like your deployment
|
this is expected unless placeholder values in the yaml are replaced. |
Hi @akirasoft1 , I'm running into a slight issue with the success of the Dynakube flux deployment not working based on the files in the addons repo I could use some help with: |
Looks like your deployment
Looks like your deployment
|
that is expected without replacing placeholder values in the variables.yaml with valid ones (in addition to the creds the operator itself is configured to fetch from secrets there is the apiurl and dynakubename that aren't secrets per se but should not be shared.) you can email me at michael.villiger @ dynatrace.com and I can exchange the values and creds with you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akirasoft1 Updates look good but there appears to be an issue with a placeholder not working for Flux and we'll need the value in there to work as-is for the GitOps to work in our ongoing testing. I think we may want to set that up on a secret if the value shouldn't be in the public facing repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so replaceme will fail as well. It needs to be replaced with a valid value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep correct - We may want to replace this with a secret if the endpoints/creds needs to be shielded from the public repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akirasoft1 Question on your change
@@ -6,8 +6,8 @@ metadata: | |||
namespace: flux-system | |||
data: | |||
# api url for dynatrace environment | |||
apiurl: "<replaceme>" | |||
apiurl: "https://fjy55252.sprint.apps.dynatracelabs.com/api" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a permanent URL? We cant have temporary URLs for this continuous testing.
Looks like your deployment
Looks like your deployment
|
i added the values back into the values file for now. You will need to reach out to me for the secrets values that you will load on your secret store... |
@akirasoft1 We cannot have hardcoded values in the variables. You can share us the secret via email which can be permanent and create ExternalSecret resource which you should reference in the values. Once you share the secret, We can create Secrets in Secrets Manager which ExternalSecret can reference and render. You can check with our other partner submissions. |
yes, all the above is how it was before, I basically reverted changes to the file and updated to a more permanent URL. if someone wants to tell me how to reference secrets inside these fluxcd things i can copy paste? |
You can check this example or any other example in partner to understand how to handle ExternalSecrets. |
Looks like your deployment
Looks like your deployment
|
we were using external secrets already for populating a secret the operator needed. i've sent an email, maybe this will work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like your deployment
Looks like your deployment
Looks like your deployment
|
Looks like your deployment
Looks like your deployment
Looks like your deployment
|
I'm going to kill this PR and open a new one as I have moved to v1.3.2 of the dynatrace operator and I believe I have something that works now. |
Looks like your deployment
Looks like your deployment
|
Issue #, if available:
227
Description of changes:
Updated to release 1.3.0 of our operator. cleaned up some api versions and added a testjob. The 10 min intervals might be a bit aggressive for running the job, most examples were only running once a day or so.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.