Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to dynatrace-operator 1.3.0 and adding test job #298

Closed
wants to merge 5 commits into from

Conversation

akirasoft1
Copy link
Contributor

Issue #, if available:
227
Description of changes:
Updated to release 1.3.0 of our operator. cleaned up some api versions and added a testjob. The 10 min intervals might be a bit aggressive for running the job, most examples were only running once a day or so.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-cwh68.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-6b784dd8b9-5l94d.
  • Pod: dynatrace-webhook-6b784dd8b9-nfj8w.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-d64f58c9c-b2nzq.
  • Pod: dynatrace-webhook-d64f58c9c-hrnk2.
  • Pod: dynatrace-webhook-d64f58c9c-htkvj.

@akirasoft1
Copy link
Contributor Author

Looks like your deployment dynatrace-operator is failing. Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-cwh68.

Looks like your deployment dynatrace-webhook is failing. Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-6b784dd8b9-5l94d.
  • Pod: dynatrace-webhook-6b784dd8b9-nfj8w.

Looks like your deployment dynatrace-webhook is failing. Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-d64f58c9c-b2nzq.
  • Pod: dynatrace-webhook-d64f58c9c-hrnk2.
  • Pod: dynatrace-webhook-d64f58c9c-htkvj.

this is expected unless placeholder values in the yaml are replaced.

@mikemcd3912
Copy link
Contributor

Hi @akirasoft1 , I'm running into a slight issue with the success of the Dynakube flux deployment not working based on the files in the addons repo I could use some help with:

image

@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-jjqbl.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-d64f58c9c-ljjhg.
  • Pod: dynatrace-webhook-d64f58c9c-sf67t.

@akirasoft1
Copy link
Contributor Author

akirasoft1 commented Oct 23, 2024

Hi @akirasoft1 , I'm running into a slight issue with the success of the Dynakube flux deployment not working based on the files in the addons repo I could use some help with:

image

that is expected without replacing placeholder values in the variables.yaml with valid ones (in addition to the creds the operator itself is configured to fetch from secrets there is the apiurl and dynakubename that aren't secrets per se but should not be shared.) you can email me at michael.villiger @ dynatrace.com and I can exchange the values and creds with you

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akirasoft1 Updates look good but there appears to be an issue with a placeholder not working for Flux and we'll need the value in there to work as-is for the GitOps to work in our ongoing testing. I think we may want to set that up on a secret if the value shouldn't be in the public facing repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be an issue with the apiurl replaceme since flux doesn't want to accept <>, please update the placeholder according to the acceptable values in the screenshot:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so replaceme will fail as well. It needs to be replaced with a valid value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep correct - We may want to replace this with a secret if the endpoints/creds needs to be shielded from the public repo

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akirasoft1 Question on your change

@@ -6,8 +6,8 @@ metadata:
namespace: flux-system
data:
# api url for dynatrace environment
apiurl: "<replaceme>"
apiurl: "https://fjy55252.sprint.apps.dynatracelabs.com/api"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a permanent URL? We cant have temporary URLs for this continuous testing.

@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-jkwnc.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-d64f58c9c-gt4g5.

@akirasoft1
Copy link
Contributor Author

i added the values back into the values file for now. You will need to reach out to me for the secrets values that you will load on your secret store...

@elamaran11
Copy link
Contributor

i added the values back into the values file for now. You will need to reach out to me for the secrets values that you will load on your secret store...

@akirasoft1 We cannot have hardcoded values in the variables. You can share us the secret via email which can be permanent and create ExternalSecret resource which you should reference in the values. Once you share the secret, We can create Secrets in Secrets Manager which ExternalSecret can reference and render. You can check with our other partner submissions.

@akirasoft1
Copy link
Contributor Author

i added the values back into the values file for now. You will need to reach out to me for the secrets values that you will load on your secret store...

@akirasoft1 We cannot have hardcoded values in the variables. You can share us the secret via email which can be permanent and create ExternalSecret resource which you should reference in the values. Once you share the secret, We can create Secrets in Secrets Manager which ExternalSecret can reference and render. You can check with our other partner submissions.

yes, all the above is how it was before, I basically reverted changes to the file and updated to a more permanent URL. if someone wants to tell me how to reference secrets inside these fluxcd things i can copy paste?

@elamaran11
Copy link
Contributor

i added the values back into the values file for now. You will need to reach out to me for the secrets values that you will load on your secret store...

@akirasoft1 We cannot have hardcoded values in the variables. You can share us the secret via email which can be permanent and create ExternalSecret resource which you should reference in the values. Once you share the secret, We can create Secrets in Secrets Manager which ExternalSecret can reference and render. You can check with our other partner submissions.

yes, all the above is how it was before, I basically reverted changes to the file and updated to a more permanent URL. if someone wants to tell me how to reference secrets inside these fluxcd things i can copy paste?

You can check this example or any other example in partner to understand how to handle ExternalSecrets.

@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-jkwnc.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-d64f58c9c-gt4g5.

@akirasoft1
Copy link
Contributor Author

i added the values back into the values file for now. You will need to reach out to me for the secrets values that you will load on your secret store...

@akirasoft1 We cannot have hardcoded values in the variables. You can share us the secret via email which can be permanent and create ExternalSecret resource which you should reference in the values. Once you share the secret, We can create Secrets in Secrets Manager which ExternalSecret can reference and render. You can check with our other partner submissions.

yes, all the above is how it was before, I basically reverted changes to the file and updated to a more permanent URL. if someone wants to tell me how to reference secrets inside these fluxcd things i can copy paste?

You can check this example or any other example in partner to understand how to handle ExternalSecrets.

we were using external secrets already for populating a secret the operator needed. i've sent an email, maybe this will work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears I'm still getting an error with the replacement of this secret value conflicting with Flux - I have it loaded and the creation was successful:
image

@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-dynatrace-operator-6d6f5855d5-sncs9.

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-qdblc.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-c989b778c-ms29k.

@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-dynatrace-operator-6d6f5855d5-sncs9.

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-6bf8447d8b-qdblc.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-c989b778c-ms29k.

@akirasoft1
Copy link
Contributor Author

I'm going to kill this PR and open a new one as I have moved to v1.3.2 of the dynatrace operator and I believe I have something that works now.

@akirasoft1 akirasoft1 closed this Nov 15, 2024
@elamaran11
Copy link
Contributor

Looks like your deployment dynatrace-operator is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-operator-56b6c4c694-gnlck.

Looks like your deployment dynatrace-webhook is failing.
Specifically, it looks like these pods are failing:

  • Pod: dynatrace-webhook-795bcc9b47-6fdqn.
  • Pod: dynatrace-webhook-795bcc9b47-792xf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants