Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to dynatrace-operator 1.3.0 and adding test job #298

Closed
wants to merge 5 commits into from
Closed

updating to dynatrace-operator 1.3.0 and adding test job #298

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c7552f
updating to dynatrace-operator 1.3.0 and adding test job
akirasoft1 Oct 11, 2024
36532ef
putting real values back in for now
akirasoft1 Nov 13, 2024
fba7298
wrong URI
akirasoft1 Nov 13, 2024
6f933fb
moving apiurl to external secret
akirasoft1 Nov 14, 2024
a5ec518
moving apiurl to flux-system ns
akirasoft1 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eks-anywhere-common/Addons/Partner/dynatrace/dynatrace-variables.yaml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be an issue with the apiurl replaceme since flux doesn't want to accept <>, please update the placeholder according to the acceptable values in the screenshot:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so replaceme will fail as well. It needs to be replaced with a valid value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep correct - We may want to replace this with a secret if the endpoints/creds needs to be shielded from the public repo

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
namespace: flux-system
data:
# api url for dynatrace environment
apiurl: "<replaceme>"
apiurl: "https://fjy55252.sprint.apps.dynatracelabs.com/api"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a permanent URL? We cant have temporary URLs for this continuous testing.

# name of secret containing tokens
dynatracesecretname: "dt-secret"
# name of cluster to be listed in Dynatrace
dynakubename: "<replaceme>"
dynakubename: "eks-flux-test-cluster"