Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --prefer-private-ip argument to the eb ssh command #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blampe
Copy link

@blampe blampe commented Aug 25, 2021

Issue #3

Description of changes:

This is a quality of life improvement for anyone who'd like to run a split-tunnel VPN.

This preserves the existing behavior of the eb ssh command but exposes a --prefer-private-ip option that uses the instance's private IP before its public one.

I've included a unit test, and I've confirmed this works as expected in my environment.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@frank-parry frank-parry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against my environment- works perfectly as described

@brandonburkett
Copy link

Did this change make it in? I would like to be able to eb ssh with private IP restrictions.

@yohanthshetty
Copy link
Contributor

Did this change make it in? I would like to be able to eb ssh with private IP restrictions.

Hi @brandonburkett, Yes, the change has been merged to the master branch. Thank You.

@yohanthshetty
Copy link
Contributor

Tested against my environment- works perfectly as described

Hi @frank-parry Can you please elaborate how you tested this
PR? Did you create the eb environment and ec2 instance in the same vpc? Or Did you set the inbound rules in the security group for that instance?

@alisson276
Copy link

It would be nice having this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants