Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): add package generation #592

Closed
wants to merge 26 commits into from
Closed

feat(ci): add package generation #592

wants to merge 26 commits into from

Commits on Sep 13, 2024

  1. fix(freelist): use uintptr_t for pointer arithmetic 

    stack-info: PR: #560, branch: aws-nslick/stack/7
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    32e5468 View commit details
    Browse the repository at this point in the history

  2. fix(tree): move declarations to top of function 

    c++ suppoorts initializers anywhere in the function, but one must not
jump over an initializer with any goto usage. Given the lack of RAII in
C, this becomes a significant painpoint.

In large to-be-eventually-refactored functions that make excessive usage
of goto, split declaration and initialization, and move all declarations
to the top of the function.

stack-info: PR: #563, branch: aws-nslick/stack/10
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    742e8d5 View commit details
    Browse the repository at this point in the history

  3. fix(api): avoid mid-function initiializers 

    c++ suppoorts initializers anywhere in the function, but one must not
jump over an initializer with any goto usage. Given the lack of RAII in
C, this becomes a significant painpoint.

Avoid naming these casts, such that the jmp's are acceptable in both cxx
and c.

stack-info: PR: #564, branch: aws-nslick/stack/11
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ff6a575 View commit details
    Browse the repository at this point in the history

  4. fix(cuda): use decltype instead of typeof for cxx 

    stack-info: PR: #565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    24c4ee0 View commit details
    Browse the repository at this point in the history

  5. fix(tuner): avoid gotos 

    stack-info: PR: #569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    142a39a View commit details
    Browse the repository at this point in the history

  6. fix(tuner): fix implicit conversions 

    cpp requires explicit cast to double here.

stack-info: PR: #573, branch: aws-nslick/stack/20
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dfcface View commit details
    Browse the repository at this point in the history

  7. feat(param): add uint parameter macro 

    stack-info: PR: #570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    12fc23e View commit details
    Browse the repository at this point in the history

  8. fix(param): move some parameters to unsigned 

    mr_key_size and eager_max_size are positive integers, avoid sign
comparison issues by treating them as such.

stack-info: PR: #571, branch: aws-nslick/stack/18
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c7d1598 View commit details
    Browse the repository at this point in the history

  9. fix(tree): avoid sign comparison issues 

    stack-info: PR: #575, branch: aws-nslick/stack/22
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4a8e756 View commit details
    Browse the repository at this point in the history

  10. fix(rdma): use COMM_ID_MASK as invalid id 

    Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.

stack-info: PR: #574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    093b75e View commit details
    Browse the repository at this point in the history

  11. fix(tree): add fallthrough switch markers 

    Signed-off-by: Nicholas Sielicki <nslick@amazon.com>

stack-info: PR: #585, branch: aws-nslick/stack/27
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    db3af3c View commit details
    Browse the repository at this point in the history

  12. fix(rdma): avoid enum/integral comparison 

    Signed-off-by: Nicholas Sielicki <nslick@amazon.com>

stack-info: PR: #586, branch: aws-nslick/stack/28
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    aad34f3 View commit details
    Browse the repository at this point in the history

  13. fix(sendrecv): add missing nccl-headers include 

    stack-info: PR: #576, branch: aws-nslick/stack/23
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bd01034 View commit details
    Browse the repository at this point in the history

  14. fix(neuron): remove const from ncclNetPlugin_v4 sym 

    const variables have internal linkage by default under c++; nvidia
interface requires it not be const because its modified during init.
Remove const for neuron, too.

stack-info: PR: #577, branch: aws-nslick/stack/24
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9d26e7d View commit details
    Browse the repository at this point in the history

  15. fix(test): fix typing issues 

    Signed-off-by: Nicholas Sielicki <nslick@amazon.com>

stack-info: PR: #587, branch: aws-nslick/stack/29
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    26b7007 View commit details
    Browse the repository at this point in the history

  16. fix(build): check features before mangling CFLAGS 

    Yet another autotools fix: If any warning/devel CFLAGS would invoke
warnings in headers used to detect dependencies, those dependencies will
fail with a highly misleading/confusing error message:

> configure: Found .git directory.  Adding -Werror to CFLAGS.
> checking if running on EC2 instance... yes
> checking if want AWS platform optimizations... yes
> checking for Libfabric 1.18.0 or later... no
> configure: error: On AWS platforms, Libfabric 1.18.0 or later is required

ie: it is not that Libfabric 1.18 was not found, it was that its headers
produced warnings. Fix this by resolving all dependencies before
modifying CFLAGS.

stack-info: PR: #589, branch: aws-nslick/stack/31
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    189af46 View commit details
    Browse the repository at this point in the history

  17. fix(tracing/nvtx): silence -Wmissing-field-initializer warnings 

    stack-info: PR: #593, branch: aws-nslick/stack/34
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bbfb706 View commit details
    Browse the repository at this point in the history

  18. fix(tree): use empty brace initializers for zero-initialization 

    prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.

stack-info: PR: #594, branch: aws-nslick/stack/35
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5502846 View commit details
    Browse the repository at this point in the history

  19. fix(platform-aws): fill all platform values 

    commit ce214aa rearranged fields such that the written initializers were
valid on most modern compilers, but it went unnoticed that this is
insufficient for AL2's ancient toolchain, which fails with:

> sorry, unimplemented: non-trivial designated initializers not supported

provide all members for all entries to fix this.

stack-info: PR: #595, branch: aws-nslick/stack/36
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c5aa794 View commit details
    Browse the repository at this point in the history

  20. feat(build): add -Wextra to "picky" compiler flags 

    Signed-off-by: Nicholas Sielicki <nslick@amazon.com>

stack-info: PR: #588, branch: aws-nslick/stack/30
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ec96367 View commit details
    Browse the repository at this point in the history

  21. feat(rdma): constrain C linkage to init 

    stack-info: PR: #591, branch: aws-nslick/stack/32
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    edca74e View commit details
    Browse the repository at this point in the history

  22. chore(build): add AC_PROG_CXX 

    stack-info: PR: #566, branch: aws-nslick/stack/13
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3251e61 View commit details
    Browse the repository at this point in the history

  23. chore(build): mpi: set mpicxx, too. 

    stack-info: PR: #567, branch: aws-nslick/stack/14
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    68343c0 View commit details
    Browse the repository at this point in the history

  24. feat(test): parse as c++ source 

    All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: #568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    17645ae View commit details
    Browse the repository at this point in the history

  25. chore(build): replace -Wc++-compat' with -x c++' 

    As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source
files in the tree are both valid C++ source code AND valid C code.

Convert wcpp-compat distcheck builds to actually build with C++, to
prevent future pull requests from breaking C++ compatibility going
forward.

stack-info: PR: #578, branch: aws-nslick/stack/25
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3413c46 View commit details
    Browse the repository at this point in the history

  26. feat(ci): add package generation 

    stack-info: PR: #592, branch: aws-nslick/stack/33
    @aws-nslick
    aws-nslick committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    83b3b05 View commit details
    Browse the repository at this point in the history