feat(ci): add package generation #592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
requested review from
rajachan,
bwbarrett and
a team
as code owners
aws-nslick
added a commit
that referenced
this pull request
Sep 12, 2024
stack-info: PR: #592, branch: aws-nslick/stack/33
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
f9ca2de
to
d56feba
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/33
branch
from
4b15a58
to
7f00b35
Compare
This was referenced Sep 12, 2024
Closed
stack-info: PR: #569, branch: aws-nslick/stack/16 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
cpp requires explicit cast to double here. stack-info: PR: #573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
stack-info: PR: #570, branch: aws-nslick/stack/17 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
mr_key_size and eager_max_size are positive integers, avoid sign comparison issues by treating them as such. stack-info: PR: #571, branch: aws-nslick/stack/18 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
stack-info: PR: #575, branch: aws-nslick/stack/22 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Previously, this used ~0 as the invalid signal. This defaults to a signed type, which breaks under -wsign-compare. Prefer to use COMM_ID_MASK as the marker. stack-info: PR: #574, branch: aws-nslick/stack/21 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Signed-off-by: Nicholas Sielicki <nslick@amazon.com> stack-info: PR: #585, branch: aws-nslick/stack/27
Signed-off-by: Nicholas Sielicki <nslick@amazon.com> stack-info: PR: #586, branch: aws-nslick/stack/28
stack-info: PR: #576, branch: aws-nslick/stack/23 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
const variables have internal linkage by default under c++; nvidia interface requires it not be const because its modified during init. Remove const for neuron, too. stack-info: PR: #577, branch: aws-nslick/stack/24 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Signed-off-by: Nicholas Sielicki <nslick@amazon.com> stack-info: PR: #587, branch: aws-nslick/stack/29
Yet another autotools fix: If any warning/devel CFLAGS would invoke warnings in headers used to detect dependencies, those dependencies will fail with a highly misleading/confusing error message: > configure: Found .git directory. Adding -Werror to CFLAGS. > checking if running on EC2 instance... yes > checking if want AWS platform optimizations... yes > checking for Libfabric 1.18.0 or later... no > configure: error: On AWS platforms, Libfabric 1.18.0 or later is required ie: it is not that Libfabric 1.18 was not found, it was that its headers produced warnings. Fix this by resolving all dependencies before modifying CFLAGS. stack-info: PR: #589, branch: aws-nslick/stack/31
stack-info: PR: #593, branch: aws-nslick/stack/34
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: #594, branch: aws-nslick/stack/35
commit ce214aa rearranged fields such that the written initializers were valid on most modern compilers, but it went unnoticed that this is insufficient for AL2's ancient toolchain, which fails with: > sorry, unimplemented: non-trivial designated initializers not supported provide all members for all entries to fix this. stack-info: PR: #595, branch: aws-nslick/stack/36
Signed-off-by: Nicholas Sielicki <nslick@amazon.com> stack-info: PR: #588, branch: aws-nslick/stack/30
stack-info: PR: #591, branch: aws-nslick/stack/32
stack-info: PR: #566, branch: aws-nslick/stack/13 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
stack-info: PR: #567, branch: aws-nslick/stack/14 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
All included headers are fully safe to be parsed as C++, so these unit tests can now use C++. Rename them to `.cc' files and use a few c++ keywords to enforce that the compiler is actually treating them as such. Actual C++ cleanups to follow later, hopefully alongside a unit test framework like gtest or catch2. stack-info: PR: #568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
stack-info: PR: #592, branch: aws-nslick/stack/33
aws-nslick
force-pushed
the
aws-nslick/stack/33
branch
from
6357799
to
83b3b05
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
3413c46
to
e537a8d
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 19, 2024
stack-info: PR: aws#592, branch: aws-nslick/stack/33
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
stack-info: PR: aws#592, branch: aws-nslick/stack/33
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
stack-info: PR: aws#592, branch: aws-nslick/stack/33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with-x c++' #578feat(ci): add package generation