feat(rdma): constrain C linkage to init #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/32
branch
from
a789535
to
065b623
Compare
This was referenced Sep 12, 2024
Merged
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 12, 2024
stack-info: PR: aws#591, branch: aws-nslick/stack/32
aws-nslick
requested review from
rajachan,
bwbarrett and
rauteric
as code owners
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 2, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 3, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 4, 2024
On builds where lttng is enabled, the inclusion of nccl_ofi_tracepoint.h pulls in <lttng/ust-utils.h>, which defines templates when __cplusplus is defined. Those templates cannot have C linkage. This file does not really need nccl_ofi_tracepoint.h; it only needs config.h to test for whether NVTX tracing is enabled and nvtx3 headers for conditionally defining the nvtx domain handles. It's also simultaneously true that the large majority of these headers are consumed only by rdma.c, so another option is to just move the guard down to where it's actually required. stack-info: PR: aws#591, branch: aws-nslick/stack/32 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
feat(rdma): constrain C linkage to init