feat(test): parse as c++ source #568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
added a commit
that referenced
this pull request
Sep 4, 2024
stack-info: PR: #568, branch: aws-nslick/stack/15
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
eb30146
to
f071592
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
579c2c2
to
e7c5e0c
Compare
This was referenced Sep 4, 2024
aws-nslick
added a commit
that referenced
this pull request
Sep 4, 2024
stack-info: PR: #568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
e7c5e0c
to
c811e90
Compare
aws-nslick
added a commit
that referenced
this pull request
Sep 4, 2024
stack-info: PR: #568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
c811e90
to
ae28f30
Compare
aws-nslick
added a commit
that referenced
this pull request
Sep 4, 2024
stack-info: PR: #568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
f97056d
to
df37f90
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 12, 2024
All included headers are fully safe to be parsed as C++, so these unit tests can now use C++. Rename them to `.cc' files and use a few c++ keywords to enforce that the compiler is actually treating them as such. Actual C++ cleanups to follow later, hopefully alongside a unit test framework like gtest or catch2. stack-info: PR: aws#568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
2 times, most recently
from
ac70e3e
to
f21589c
Compare
This was referenced Sep 12, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
f21589c
to
2d28df3
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
2d28df3
to
4b08032
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
4b08032
to
17645ae
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
17645ae
to
5d80033
Compare
All included headers are fully safe to be parsed as C++, so these unit tests can now use C++. Rename them to `.cc' files and use a few c++ keywords to enforce that the compiler is actually treating them as such. Actual C++ cleanups to follow later, hopefully alongside a unit test framework like gtest or catch2. stack-info: PR: #568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/15
branch
from
5d80033
to
ee3a21e
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
All included headers are fully safe to be parsed as C++, so these unit tests can now use C++. Rename them to `.cc' files and use a few c++ keywords to enforce that the compiler is actually treating them as such. Actual C++ cleanups to follow later, hopefully alongside a unit test framework like gtest or catch2. stack-info: PR: aws#568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
All included headers are fully safe to be parsed as C++, so these unit tests can now use C++. Rename them to `.cc' files and use a few c++ keywords to enforce that the compiler is actually treating them as such. Actual C++ cleanups to follow later, hopefully alongside a unit test framework like gtest or catch2. stack-info: PR: aws#568, branch: aws-nslick/stack/15 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
feat(test): parse as c++ source
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.
Signed-off-by: Nicholas Sielicki nslick@amazon.com