fix(rdma): fi_{send,write}data: do arithmetic on uintptr #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/4
branch
from
179c91f
to
348761d
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
58faa00
to
1906685
Compare
This was referenced Sep 4, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
1906685
to
8d93f95
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
8d93f95
to
af00dd1
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
af00dd1
to
54488ee
Compare
aws-nslick
changed the title
Merged
rauteric
previously approved these changes
Sep 5, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
54488ee
to
232e583
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
232e583
to
cdba4c1
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
cdba4c1
to
a6c1d0f
Compare
|
bot:aws:retest |
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
a6c1d0f
to
9d0c1d5
Compare
void pointer arithmetic is illegal in c++; cast to uintptr, do the offset, then cast to void* to pass to libfabric. stack-info: PR: #558, branch: aws-nslick/stack/5 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/5
branch
from
9d0c1d5
to
46b6733
Compare
rauteric
approved these changes
Sep 10, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
void pointer arithmetic is illegal in c++; cast to uintptr, do the offset, then cast to void* to pass to libfabric. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(rdma): fi_{send,write}data: do arithmetic on uintptr
void pointer arithmetic is illegal in c++; cast to uintptr, do the
offset, then cast to void* to pass to libfabric.
Signed-off-by: Nicholas Sielicki nslick@amazon.com