nit: msgbuff: avoid typedef hell #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/8
branch
from
16bcbc1
to
bdcd2f1
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/9
branch
from
ddc2dc3
to
a72658c
Compare
This was referenced Sep 4, 2024
bwbarrett
requested changes
Sep 4, 2024
| @@ -43,7 +43,7 @@ extern "C" { | |||
| */ | |||
There was a problem hiding this comment.
Similar to #561, this is not the solution we're looking for.
stack-info: PR: #562, branch: aws-nslick/stack/9 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/9
branch
from
a72658c
to
e6f6766
Compare
|
Abandoning this as the build works without it, and it is contentious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
nit: msgbuff: avoid typedef hell
Signed-off-by: Nicholas Sielicki nslick@amazon.com