-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(freelist): use uintptr_t for pointer arithmetic #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 4, 2024 16:45
07d8b1c
to
ffbace2
Compare
This was referenced Sep 4, 2024
bwbarrett
previously requested changes
Sep 4, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 4, 2024 19:07
ffbace2
to
74856f4
Compare
aws-nslick
changed the title
freelist: use uintptr_t where appropriate
freelist: use uintptr_t for pointer arithmetic
Sep 4, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 4, 2024 19:16
74856f4
to
36d93ae
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 4, 2024 20:25
36d93ae
to
95a542e
Compare
aws-nslick
changed the title
freelist: use uintptr_t for pointer arithmetic
fix(freelist): use uintptr_t for pointer arithmetic
Sep 4, 2024
This was referenced Sep 11, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 11, 2024 23:12
ac138a2
to
804880e
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 12, 2024 00:17
804880e
to
79ac1ff
Compare
This was referenced Sep 12, 2024
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 12, 2024
stack-info: PR: aws#560, branch: aws-nslick/stack/7 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This was referenced Sep 12, 2024
stack-info: PR: #560, branch: aws-nslick/stack/7 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
September 13, 2024 17:49
79ac1ff
to
32e5468
Compare
rauteric
approved these changes
Sep 14, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with
-x c++' #578fix(freelist): use uintptr_t for pointer arithmetic
Signed-off-by: Nicholas Sielicki nslick@amazon.com