fix(platform-aws): fill all platform values #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
f7f49ac
to
af08352
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/36
branch
from
516b046
to
dbb082f
Compare
This was referenced Sep 12, 2024
aws-nslick
requested review from
rajachan,
bwbarrett and
rauteric
as code owners
aws-nslick
force-pushed
the
aws-nslick/stack/36
branch
from
dbb082f
to
f75768d
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/36
branch
from
f75768d
to
258ac07
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/36
branch
from
258ac07
to
c5aa794
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/36
branch
from
c5aa794
to
54cff5b
Compare
commit ce214aa rearranged fields such that the written initializers were valid on most modern compilers, but it went unnoticed that this is insufficient for AL2's ancient toolchain, which fails with: > sorry, unimplemented: non-trivial designated initializers not supported provide all members for all entries to fix this. stack-info: PR: #595, branch: aws-nslick/stack/36
aws-nslick
force-pushed
the
aws-nslick/stack/36
branch
from
54cff5b
to
6981153
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
commit ce214aa rearranged fields such that the written initializers were valid on most modern compilers, but it went unnoticed that this is insufficient for AL2's ancient toolchain, which fails with: > sorry, unimplemented: non-trivial designated initializers not supported provide all members for all entries to fix this. stack-info: PR: aws#595, branch: aws-nslick/stack/36
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
commit ce214aa rearranged fields such that the written initializers were valid on most modern compilers, but it went unnoticed that this is insufficient for AL2's ancient toolchain, which fails with: > sorry, unimplemented: non-trivial designated initializers not supported provide all members for all entries to fix this. stack-info: PR: aws#595, branch: aws-nslick/stack/36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(platform-aws): fill all platform values
commit ce214aa rearranged fields such that the written initializers were
valid on most modern compilers, but it went unnoticed that this is
insufficient for AL2's ancient toolchain, which fails with:
provide all members for all entries to fix this.