Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): mpi: set mpicxx, too. #567

Closed
wants to merge 1 commit into from

Conversation

@aws-nslick aws-nslick requested review from bwbarrett and a team as code owners September 4, 2024 16:44
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 4, 2024 19:07
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 4, 2024 19:08
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 4, 2024 19:16
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 4, 2024 19:17
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 4, 2024 20:25
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 12, 2024 00:58
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 12, 2024 01:10
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 12, 2024 01:11
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 12, 2024 01:51
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 12, 2024 01:52
rauteric
rauteric previously approved these changes Sep 13, 2024
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 13, 2024 17:49
@aws-nslick aws-nslick dismissed rauteric’s stale review September 13, 2024 17:49

The base branch was changed.

@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 13, 2024 17:51
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 14, 2024 22:37
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 14, 2024 22:38
stack-info: PR: #567, branch: aws-nslick/stack/14
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/13 to master September 17, 2024 20:25
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/13 September 17, 2024 20:26
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
@aws-nslick
Copy link
Contributor Author

Squashed this into #568

@aws-nslick aws-nslick closed this Sep 26, 2024
@aws-nslick aws-nslick deleted the aws-nslick/stack/14 branch September 27, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants