Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disable Sudo] Invoking sudo_access from Slurm cookbook when updating cluster #2637

Closed
wants to merge 1 commit into from

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Feb 1, 2024

Description of changes

  • Invoking sudo_access from Slurm cookbook when updating cluster

Tests

  • Paased Integ tests
    * create:test_create.py::test_create_disable_sudo_access_for_default_user:
    * networking:test_cluster_networking.py::test_cluster_in_no_internet_subnet:
    * createami:test_createami.py::test_build_image:

aws/aws-parallelcluster#6086

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5002188) 0.00% compared to head (525fcc2) 75.56%.
Report is 3 commits behind head on develop.

❗ Current head 525fcc2 differs from pull request most recent head 1da238b. Consider uploading reports for the commit 1da238b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2637       +/-   ##
============================================
+ Coverage         0   75.56%   +75.56%     
============================================
  Files            0       16       +16     
  Lines            0     2132     +2132     
============================================
+ Hits             0     1611     +1611     
- Misses           0      521      +521     
Flag Coverage Δ
unittests 75.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 force-pushed the develop-new branch 2 times, most recently from 8a717cc to 15e1c3b Compare February 6, 2024 15:07
@himani2411 himani2411 marked this pull request as draft February 6, 2024 19:48
@himani2411 himani2411 changed the title [Disable Sudo] Moving sudo_access in Slurm cookbook [Disable Sudo] Invoking sudo_access from Slurm cookbook when updating cluster Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant