-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Disable Sudo]Move DisableSudoAccessForDefaultUser under DeploymentSettings #6086
Conversation
fadd586
to
288d724
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #6086 +/- ##
===========================================
- Coverage 90.24% 90.24% -0.01%
===========================================
Files 181 181
Lines 15869 15887 +18
===========================================
+ Hits 14321 14337 +16
- Misses 1548 1550 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2b8bab9
to
5a85571
Compare
…ings for Cluster Separate ImageBuilder and Cluster Deployment Settings
5a85571
to
a75a6b6
Compare
a75a6b6
to
9b57371
Compare
...uster/schemas/test_imagebuilder_schema/test_imagebuilder_schema/imagebuilder_schema_dev.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with only minor comments. Dismissing approval because some checks are failing.
9b57371
to
bc375b5
Compare
bc375b5
to
747b85b
Compare
Description of changes
Tests
* create:test_create.py::test_create_disable_sudo_access_for_default_user:
* networking:test_cluster_networking.py::test_cluster_in_no_internet_subnet:
* createami:test_createami.py::test_build_image:
aws/aws-parallelcluster-cookbook#2637
References
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.