Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disable Sudo]Move DisableSudoAccessForDefaultUser under DeploymentSettings #6086

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Feb 6, 2024

Description of changes

  • Move DisableSudoAccessForDefaultUser under DeploymentSettings

Tests

  • Unit Tests
  • Paased Integ tests
    * create:test_create.py::test_create_disable_sudo_access_for_default_user:
    * networking:test_cluster_networking.py::test_cluster_in_no_internet_subnet:
    * createami:test_createami.py::test_build_image:

aws/aws-parallelcluster-cookbook#2637

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Feb 6, 2024
@himani2411 himani2411 requested review from a team as code owners February 6, 2024 00:10
@himani2411 himani2411 force-pushed the develop-sudo-integ-test branch 3 times, most recently from fadd586 to 288d724 Compare February 6, 2024 00:57
@himani2411 himani2411 marked this pull request as draft February 6, 2024 19:48
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (538cf06) 90.24% compared to head (4e139c9) 90.24%.

Files Patch % Lines
cli/src/pcluster/config/imagebuilder_config.py 80.00% 1 Missing ⚠️
cli/src/pcluster/schemas/common_schema.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6086      +/-   ##
===========================================
- Coverage    90.24%   90.24%   -0.01%     
===========================================
  Files          181      181              
  Lines        15869    15887      +18     
===========================================
+ Hits         14321    14337      +16     
- Misses        1548     1550       +2     
Flag Coverage Δ
unittests 90.24% <92.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 marked this pull request as ready for review February 8, 2024 04:57
Copy link
Contributor

@gmarciani gmarciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only minor comments. Dismissing approval because some checks are failing.

@himani2411 himani2411 merged commit 14ce3d7 into aws:develop Feb 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants