Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix requestless json #2634

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix requestless json #2634

merged 1 commit into from
Aug 22, 2023

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Aug 21, 2023

Issue #, if available:

issues/2631

Description of changes:

Currently for services that have apis that have no request objects we do not generate a request object. This presents several gaps in our workflows. Namely adding the X-Amz-Target header for json services is done in other SDKs in the json serialization (java sdk, go sdk). This change adds empty request objects that will not be required when calling their corresponding APIs.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl changed the title Sb/fix requestless json fix requestless json Aug 21, 2023
@sbiscigl sbiscigl marked this pull request as ready for review August 22, 2023 15:07
@sbiscigl sbiscigl merged commit a5361f8 into main Aug 22, 2023
3 checks passed
@sbiscigl sbiscigl deleted the sb/fix-requestless-json branch August 22, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants