Support passing ClientConfiguration to SSOCredentialsProvider. #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sbiscigl
reviewed
Sep 10, 2024
src/aws-cpp-sdk-core/source/auth/bearer-token-provider/SSOBearerTokenProvider.cpp
Show resolved
Hide resolved
teo-tsirpanis
force-pushed
the
sso-clientconfig
branch
from
c4c4559
to
153fdff
Compare
SergeyRyabinin
approved these changes
Sep 18, 2024
sbiscigl
approved these changes
Sep 18, 2024
sbiscigl
requested changes
Sep 18, 2024
| AWS_LOGSTREAM_INFO(SSO_CREDENTIALS_PROVIDER_LOG_TAG, "Setting sso credentials provider to read config from " << m_profileToUse); | ||
| } | ||
|
|
||
| SSOCredentialsProvider::SSOCredentialsProvider(const Aws::String& profile, std::shared_ptr<const Client::ClientConfiguration> config) : |
There was a problem hiding this comment.
MSVC CI build isnt liking Client::ClientConfiguration
C:/aws-sdk-cpp/src/aws-cpp-sdk-core/source/auth/SSOCredentialsProvider.cpp(39): error C2653: 'Client': is not a class or namespace name (compiling source file C:\aws-cpp-sdk-core\ub_core.cpp)
C:/aws-sdk-cpp/src/aws-cpp-sdk-core/source/auth/bearer-token-provider/SSOBearerTokenProvider.cpp(38): error C2653: 'Client': is not a class or namespace name (compiling source file C:\aws-cpp-sdk-core\ub_core.cpp)
Gotta make it Aws:Client::ClientConfiguration in both SSOCredentialsProvider and SSOBearerTokenProvider
teo-tsirpanis
force-pushed
the
sso-clientconfig
branch
from
a046a6c
to
fa6fb75
Compare
teo-tsirpanis
force-pushed
the
sso-clientconfig
branch
from
fa6fb75
to
27f6d0e
Compare
sbiscigl
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds a constructor overload to
SSOCredentialsProviderthat allows passing a pointer to aClientConfigurationobject. This is necessary for scenarios like specifying custom CA certificates or custom retry policies.I also slightly restructured the code to not rely on the
ClientConfigto pass options like the region or the scheme, passing them instead as separate parameters.Let me know how I should test this.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.