Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit Jackson dependency from v2-migration module #5612

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Remove explicit Jackson dependency from v2-migration module #5612

merged 4 commits into from
Sep 23, 2024

Conversation

zoewangg
Copy link
Contributor

Motivation and Context

Remove explicit Jackson dependency from v2-migration module since we fixed internal import and it's no longer needed.

@zoewangg zoewangg requested a review from a team as a code owner September 19, 2024 16:20
@zoewangg zoewangg force-pushed the zoewang/removeJacksonDependency branch from 344dd6d to 5f6eccb Compare September 23, 2024 16:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zoewangg zoewangg added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit 4447843 Sep 23, 2024
16 of 17 checks passed
@zoewangg zoewangg deleted the zoewang/removeJacksonDependency branch September 23, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoewangg @dagnir @davidh44