Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 15, 2025

Issue

#3979

Description

Uses window.DOMParser in browsers instead of fast-xml-parser

Testing

new unit tests, also ran all of our existing S3 tests with the browser bundle, confirming that it is using the replacement.

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts).
    • XML parsing is only used on the response, at which point unit tests do the same job
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner September 15, 2025 19:21
@kuhe
Copy link
Contributor Author

kuhe commented Sep 15, 2025

  • update root level aggregate unit and browser tests to exclude/include the xml-parser test file

@kuhe kuhe force-pushed the feat/xml branch 3 times, most recently from 3b6b9ae to c2f834a Compare September 17, 2025 17:09
@trivikr
Copy link
Member

trivikr commented Sep 17, 2025

Protocol tests need to be updated to use DOMParser

It can be done in alternative PR as a PoC, and merged, before taking up this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants