Skip to content

feat(xml-builder): use DOMParser for browser XML parsing #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2025
+2,244 −1,970
Merged

feat(xml-builder): use DOMParser for browser XML parsing #7347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0271e06
feat(xml-builder): use DOMParser for browser XML parsing
kuhe Sep 15, 2025
eff19fe
test(xml-builder): move tests to browser group
kuhe Sep 16, 2025
36d6269
test: verify DOMParser in Node.js
kuhe Sep 17, 2025
689a1a6
fix: update empty aggregate shape string check with trim
kuhe Sep 17, 2025
0cfc2e5
feat(xml-builder): restore fast-xml-parser in Node.js
kuhe Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 67 additions & 67 deletions clients/client-auto-scaling/src/protocols/Aws_query.ts
View file
Open in desktop

Large diffs are not rendered by default.

166 changes: 83 additions & 83 deletions clients/client-cloudformation/src/protocols/Aws_query.ts
View file
Open in desktop

Large diffs are not rendered by default.

150 changes: 75 additions & 75 deletions clients/client-cloudfront/src/protocols/Aws_restXml.ts
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions clients/client-cloudsearch/src/protocols/Aws_query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2369,7 +2369,7 @@ const de_BaseException = (output: any, context: __SerdeContext): BaseException =
*/
const de_BuildSuggestersResponse = (output: any, context: __SerdeContext): BuildSuggestersResponse => {
const contents: any = {};
if (output.FieldNames === "") {
if (String(output.FieldNames).trim() === "") {
contents[_FN] = [];
} else if (output[_FN] != null && output[_FN][_m] != null) {
contents[_FN] = de_FieldNameList(__getArrayIfSingleItem(output[_FN][_m]), context);
Expand Down Expand Up @@ -2541,7 +2541,7 @@ const de_DeleteSuggesterResponse = (output: any, context: __SerdeContext): Delet
*/
const de_DescribeAnalysisSchemesResponse = (output: any, context: __SerdeContext): DescribeAnalysisSchemesResponse => {
const contents: any = {};
if (output.AnalysisSchemes === "") {
if (String(output.AnalysisSchemes).trim() === "") {
contents[_ASna] = [];
} else if (output[_ASna] != null && output[_ASna][_m] != null) {
contents[_ASna] = de_AnalysisSchemeStatusList(__getArrayIfSingleItem(output[_ASna][_m]), context);
Expand Down Expand Up @@ -2582,7 +2582,7 @@ const de_DescribeDomainEndpointOptionsResponse = (
*/
const de_DescribeDomainsResponse = (output: any, context: __SerdeContext): DescribeDomainsResponse => {
const contents: any = {};
if (output.DomainStatusList === "") {
if (String(output.DomainStatusList).trim() === "") {
contents[_DSL] = [];
} else if (output[_DSL] != null && output[_DSL][_m] != null) {
contents[_DSL] = de_DomainStatusList(__getArrayIfSingleItem(output[_DSL][_m]), context);
Expand All @@ -2595,7 +2595,7 @@ const de_DescribeDomainsResponse = (output: any, context: __SerdeContext): Descr
*/
const de_DescribeExpressionsResponse = (output: any, context: __SerdeContext): DescribeExpressionsResponse => {
const contents: any = {};
if (output.Expressions === "") {
if (String(output.Expressions).trim() === "") {
contents[_Ex] = [];
} else if (output[_Ex] != null && output[_Ex][_m] != null) {
contents[_Ex] = de_ExpressionStatusList(__getArrayIfSingleItem(output[_Ex][_m]), context);
Expand All @@ -2608,7 +2608,7 @@ const de_DescribeExpressionsResponse = (output: any, context: __SerdeContext): D
*/
const de_DescribeIndexFieldsResponse = (output: any, context: __SerdeContext): DescribeIndexFieldsResponse => {
const contents: any = {};
if (output.IndexFields === "") {
if (String(output.IndexFields).trim() === "") {
contents[_IFn] = [];
} else if (output[_IFn] != null && output[_IFn][_m] != null) {
contents[_IFn] = de_IndexFieldStatusList(__getArrayIfSingleItem(output[_IFn][_m]), context);
Expand Down Expand Up @@ -2649,7 +2649,7 @@ const de_DescribeServiceAccessPoliciesResponse = (
*/
const de_DescribeSuggestersResponse = (output: any, context: __SerdeContext): DescribeSuggestersResponse => {
const contents: any = {};
if (output.Suggesters === "") {
if (String(output.Suggesters).trim() === "") {
contents[_Sug] = [];
} else if (output[_Sug] != null && output[_Sug][_m] != null) {
contents[_Sug] = de_SuggesterStatusList(__getArrayIfSingleItem(output[_Sug][_m]), context);
Expand Down Expand Up @@ -2891,7 +2891,7 @@ const de_FieldNameList = (output: any, context: __SerdeContext): string[] => {
*/
const de_IndexDocumentsResponse = (output: any, context: __SerdeContext): IndexDocumentsResponse => {
const contents: any = {};
if (output.FieldNames === "") {
if (String(output.FieldNames).trim() === "") {
contents[_FN] = [];
} else if (output[_FN] != null && output[_FN][_m] != null) {
contents[_FN] = de_FieldNameList(__getArrayIfSingleItem(output[_FN][_m]), context);
Expand Down Expand Up @@ -3107,7 +3107,7 @@ const de_Limits = (output: any, context: __SerdeContext): Limits => {
*/
const de_ListDomainNamesResponse = (output: any, context: __SerdeContext): ListDomainNamesResponse => {
const contents: any = {};
if (output.DomainNames === "") {
if (String(output.DomainNames).trim() === "") {
contents[_DNo] = {};
} else if (output[_DNo] != null && output[_DNo][_e] != null) {
contents[_DNo] = de_DomainNameMap(__getArrayIfSingleItem(output[_DNo][_e]), context);
Expand Down
104 changes: 52 additions & 52 deletions clients/client-cloudwatch/src/protocols/Aws_query.ts
View file
Open in desktop

Large diffs are not rendered by default.

84 changes: 42 additions & 42 deletions clients/client-docdb/src/protocols/Aws_query.ts
View file
Open in desktop

Large diffs are not rendered by default.

1,416 changes: 708 additions & 708 deletions clients/client-ec2/src/protocols/Aws_ec2.ts
View file
Open in desktop

Large diffs are not rendered by default.

82 changes: 41 additions & 41 deletions clients/client-elastic-beanstalk/src/protocols/Aws_query.ts
View file
Open in desktop

Large diffs are not rendered by default.

116 changes: 58 additions & 58 deletions clients/client-elastic-load-balancing-v2/src/protocols/Aws_query.ts
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions clients/client-elastic-load-balancing/src/protocols/Aws_query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2892,7 +2892,7 @@ const de_AccessPointNotFoundException = (output: any, context: __SerdeContext):
*/
const de_AddAvailabilityZonesOutput = (output: any, context: __SerdeContext): AddAvailabilityZonesOutput => {
const contents: any = {};
if (output.AvailabilityZones === "") {
if (String(output.AvailabilityZones).trim() === "") {
contents[_AZ] = [];
} else if (output[_AZ] != null && output[_AZ][_m] != null) {
contents[_AZ] = de_AvailabilityZones(__getArrayIfSingleItem(output[_AZ][_m]), context);
Expand Down Expand Up @@ -2966,7 +2966,7 @@ const de_ApplySecurityGroupsToLoadBalancerOutput = (
context: __SerdeContext
): ApplySecurityGroupsToLoadBalancerOutput => {
const contents: any = {};
if (output.SecurityGroups === "") {
if (String(output.SecurityGroups).trim() === "") {
contents[_SG] = [];
} else if (output[_SG] != null && output[_SG][_m] != null) {
contents[_SG] = de_SecurityGroups(__getArrayIfSingleItem(output[_SG][_m]), context);
Expand All @@ -2982,7 +2982,7 @@ const de_AttachLoadBalancerToSubnetsOutput = (
context: __SerdeContext
): AttachLoadBalancerToSubnetsOutput => {
const contents: any = {};
if (output.Subnets === "") {
if (String(output.Subnets).trim() === "") {
contents[_S] = [];
} else if (output[_S] != null && output[_S][_m] != null) {
contents[_S] = de_Subnets(__getArrayIfSingleItem(output[_S][_m]), context);
Expand All @@ -3009,7 +3009,7 @@ const de_BackendServerDescription = (output: any, context: __SerdeContext): Back
if (output[_IPn] != null) {
contents[_IPn] = __strictParseInt32(output[_IPn]) as number;
}
if (output.PolicyNames === "") {
if (String(output.PolicyNames).trim() === "") {
contents[_PNo] = [];
} else if (output[_PNo] != null && output[_PNo][_m] != null) {
contents[_PNo] = de_PolicyNames(__getArrayIfSingleItem(output[_PNo][_m]), context);
Expand Down Expand Up @@ -3181,7 +3181,7 @@ const de_DependencyThrottleException = (output: any, context: __SerdeContext): D
*/
const de_DeregisterEndPointsOutput = (output: any, context: __SerdeContext): DeregisterEndPointsOutput => {
const contents: any = {};
if (output.Instances === "") {
if (String(output.Instances).trim() === "") {
contents[_I] = [];
} else if (output[_I] != null && output[_I][_m] != null) {
contents[_I] = de_Instances(__getArrayIfSingleItem(output[_I][_m]), context);
Expand All @@ -3194,7 +3194,7 @@ const de_DeregisterEndPointsOutput = (output: any, context: __SerdeContext): Der
*/
const de_DescribeAccessPointsOutput = (output: any, context: __SerdeContext): DescribeAccessPointsOutput => {
const contents: any = {};
if (output.LoadBalancerDescriptions === "") {
if (String(output.LoadBalancerDescriptions).trim() === "") {
contents[_LBD] = [];
} else if (output[_LBD] != null && output[_LBD][_m] != null) {
contents[_LBD] = de_LoadBalancerDescriptions(__getArrayIfSingleItem(output[_LBD][_m]), context);
Expand All @@ -3210,7 +3210,7 @@ const de_DescribeAccessPointsOutput = (output: any, context: __SerdeContext): De
*/
const de_DescribeAccountLimitsOutput = (output: any, context: __SerdeContext): DescribeAccountLimitsOutput => {
const contents: any = {};
if (output.Limits === "") {
if (String(output.Limits).trim() === "") {
contents[_Li] = [];
} else if (output[_Li] != null && output[_Li][_m] != null) {
contents[_Li] = de_Limits(__getArrayIfSingleItem(output[_Li][_m]), context);
Expand All @@ -3226,7 +3226,7 @@ const de_DescribeAccountLimitsOutput = (output: any, context: __SerdeContext): D
*/
const de_DescribeEndPointStateOutput = (output: any, context: __SerdeContext): DescribeEndPointStateOutput => {
const contents: any = {};
if (output.InstanceStates === "") {
if (String(output.InstanceStates).trim() === "") {
contents[_IS] = [];
} else if (output[_IS] != null && output[_IS][_m] != null) {
contents[_IS] = de_InstanceStates(__getArrayIfSingleItem(output[_IS][_m]), context);
Expand Down Expand Up @@ -3256,7 +3256,7 @@ const de_DescribeLoadBalancerPoliciesOutput = (
context: __SerdeContext
): DescribeLoadBalancerPoliciesOutput => {
const contents: any = {};
if (output.PolicyDescriptions === "") {
if (String(output.PolicyDescriptions).trim() === "") {
contents[_PD] = [];
} else if (output[_PD] != null && output[_PD][_m] != null) {
contents[_PD] = de_PolicyDescriptions(__getArrayIfSingleItem(output[_PD][_m]), context);
Expand All @@ -3272,7 +3272,7 @@ const de_DescribeLoadBalancerPolicyTypesOutput = (
context: __SerdeContext
): DescribeLoadBalancerPolicyTypesOutput => {
const contents: any = {};
if (output.PolicyTypeDescriptions === "") {
if (String(output.PolicyTypeDescriptions).trim() === "") {
contents[_PTD] = [];
} else if (output[_PTD] != null && output[_PTD][_m] != null) {
contents[_PTD] = de_PolicyTypeDescriptions(__getArrayIfSingleItem(output[_PTD][_m]), context);
Expand All @@ -3285,7 +3285,7 @@ const de_DescribeLoadBalancerPolicyTypesOutput = (
*/
const de_DescribeTagsOutput = (output: any, context: __SerdeContext): DescribeTagsOutput => {
const contents: any = {};
if (output.TagDescriptions === "") {
if (String(output.TagDescriptions).trim() === "") {
contents[_TD] = [];
} else if (output[_TD] != null && output[_TD][_m] != null) {
contents[_TD] = de_TagDescriptions(__getArrayIfSingleItem(output[_TD][_m]), context);
Expand All @@ -3301,7 +3301,7 @@ const de_DetachLoadBalancerFromSubnetsOutput = (
context: __SerdeContext
): DetachLoadBalancerFromSubnetsOutput => {
const contents: any = {};
if (output.Subnets === "") {
if (String(output.Subnets).trim() === "") {
contents[_S] = [];
} else if (output[_S] != null && output[_S][_m] != null) {
contents[_S] = de_Subnets(__getArrayIfSingleItem(output[_S][_m]), context);
Expand Down Expand Up @@ -3571,7 +3571,7 @@ const de_ListenerDescription = (output: any, context: __SerdeContext): ListenerD
if (output[_Lis] != null) {
contents[_Lis] = de_Listener(output[_Lis], context);
}
if (output.PolicyNames === "") {
if (String(output.PolicyNames).trim() === "") {
contents[_PNo] = [];
} else if (output[_PNo] != null && output[_PNo][_m] != null) {
contents[_PNo] = de_PolicyNames(__getArrayIfSingleItem(output[_PNo][_m]), context);
Expand Down Expand Up @@ -3632,7 +3632,7 @@ const de_LoadBalancerAttributes = (output: any, context: __SerdeContext): LoadBa
if (output[_CS] != null) {
contents[_CS] = de_ConnectionSettings(output[_CS], context);
}
if (output.AdditionalAttributes === "") {
if (String(output.AdditionalAttributes).trim() === "") {
contents[_AA] = [];
} else if (output[_AA] != null && output[_AA][_m] != null) {
contents[_AA] = de_AdditionalAttributes(__getArrayIfSingleItem(output[_AA][_m]), context);
Expand All @@ -3657,33 +3657,33 @@ const de_LoadBalancerDescription = (output: any, context: __SerdeContext): LoadB
if (output[_CHZNID] != null) {
contents[_CHZNID] = __expectString(output[_CHZNID]);
}
if (output.ListenerDescriptions === "") {
if (String(output.ListenerDescriptions).trim() === "") {
contents[_LD] = [];
} else if (output[_LD] != null && output[_LD][_m] != null) {
contents[_LD] = de_ListenerDescriptions(__getArrayIfSingleItem(output[_LD][_m]), context);
}
if (output[_Po] != null) {
contents[_Po] = de_Policies(output[_Po], context);
}
if (output.BackendServerDescriptions === "") {
if (String(output.BackendServerDescriptions).trim() === "") {
contents[_BSD] = [];
} else if (output[_BSD] != null && output[_BSD][_m] != null) {
contents[_BSD] = de_BackendServerDescriptions(__getArrayIfSingleItem(output[_BSD][_m]), context);
}
if (output.AvailabilityZones === "") {
if (String(output.AvailabilityZones).trim() === "") {
contents[_AZ] = [];
} else if (output[_AZ] != null && output[_AZ][_m] != null) {
contents[_AZ] = de_AvailabilityZones(__getArrayIfSingleItem(output[_AZ][_m]), context);
}
if (output.Subnets === "") {
if (String(output.Subnets).trim() === "") {
contents[_S] = [];
} else if (output[_S] != null && output[_S][_m] != null) {
contents[_S] = de_Subnets(__getArrayIfSingleItem(output[_S][_m]), context);
}
if (output[_VPCI] != null) {
contents[_VPCI] = __expectString(output[_VPCI]);
}
if (output.Instances === "") {
if (String(output.Instances).trim() === "") {
contents[_I] = [];
} else if (output[_I] != null && output[_I][_m] != null) {
contents[_I] = de_Instances(__getArrayIfSingleItem(output[_I][_m]), context);
Expand All @@ -3694,7 +3694,7 @@ const de_LoadBalancerDescription = (output: any, context: __SerdeContext): LoadB
if (output[_SSG] != null) {
contents[_SSG] = de_SourceSecurityGroup(output[_SSG], context);
}
if (output.SecurityGroups === "") {
if (String(output.SecurityGroups).trim() === "") {
contents[_SG] = [];
} else if (output[_SG] != null && output[_SG][_m] != null) {
contents[_SG] = de_SecurityGroups(__getArrayIfSingleItem(output[_SG][_m]), context);
Expand Down Expand Up @@ -3752,17 +3752,17 @@ const de_OperationNotPermittedException = (output: any, context: __SerdeContext)
*/
const de_Policies = (output: any, context: __SerdeContext): Policies => {
const contents: any = {};
if (output.AppCookieStickinessPolicies === "") {
if (String(output.AppCookieStickinessPolicies).trim() === "") {
contents[_ACSP] = [];
} else if (output[_ACSP] != null && output[_ACSP][_m] != null) {
contents[_ACSP] = de_AppCookieStickinessPolicies(__getArrayIfSingleItem(output[_ACSP][_m]), context);
}
if (output.LBCookieStickinessPolicies === "") {
if (String(output.LBCookieStickinessPolicies).trim() === "") {
contents[_LBCSP] = [];
} else if (output[_LBCSP] != null && output[_LBCSP][_m] != null) {
contents[_LBCSP] = de_LBCookieStickinessPolicies(__getArrayIfSingleItem(output[_LBCSP][_m]), context);
}
if (output.OtherPolicies === "") {
if (String(output.OtherPolicies).trim() === "") {
contents[_OP] = [];
} else if (output[_OP] != null && output[_OP][_m] != null) {
contents[_OP] = de_PolicyNames(__getArrayIfSingleItem(output[_OP][_m]), context);
Expand Down Expand Up @@ -3840,7 +3840,7 @@ const de_PolicyDescription = (output: any, context: __SerdeContext): PolicyDescr
if (output[_PTN] != null) {
contents[_PTN] = __expectString(output[_PTN]);
}
if (output.PolicyAttributeDescriptions === "") {
if (String(output.PolicyAttributeDescriptions).trim() === "") {
contents[_PAD] = [];
} else if (output[_PAD] != null && output[_PAD][_m] != null) {
contents[_PAD] = de_PolicyAttributeDescriptions(__getArrayIfSingleItem(output[_PAD][_m]), context);
Expand Down Expand Up @@ -3892,7 +3892,7 @@ const de_PolicyTypeDescription = (output: any, context: __SerdeContext): PolicyT
if (output[_D] != null) {
contents[_D] = __expectString(output[_D]);
}
if (output.PolicyAttributeTypeDescriptions === "") {
if (String(output.PolicyAttributeTypeDescriptions).trim() === "") {
contents[_PATD] = [];
} else if (output[_PATD] != null && output[_PATD][_m] != null) {
contents[_PATD] = de_PolicyAttributeTypeDescriptions(__getArrayIfSingleItem(output[_PATD][_m]), context);
Expand Down Expand Up @@ -3927,7 +3927,7 @@ const de_PolicyTypeNotFoundException = (output: any, context: __SerdeContext): P
*/
const de_RegisterEndPointsOutput = (output: any, context: __SerdeContext): RegisterEndPointsOutput => {
const contents: any = {};
if (output.Instances === "") {
if (String(output.Instances).trim() === "") {
contents[_I] = [];
} else if (output[_I] != null && output[_I][_m] != null) {
contents[_I] = de_Instances(__getArrayIfSingleItem(output[_I][_m]), context);
Expand All @@ -3940,7 +3940,7 @@ const de_RegisterEndPointsOutput = (output: any, context: __SerdeContext): Regis
*/
const de_RemoveAvailabilityZonesOutput = (output: any, context: __SerdeContext): RemoveAvailabilityZonesOutput => {
const contents: any = {};
if (output.AvailabilityZones === "") {
if (String(output.AvailabilityZones).trim() === "") {
contents[_AZ] = [];
} else if (output[_AZ] != null && output[_AZ][_m] != null) {
contents[_AZ] = de_AvailabilityZones(__getArrayIfSingleItem(output[_AZ][_m]), context);
Expand Down Expand Up @@ -4058,7 +4058,7 @@ const de_TagDescription = (output: any, context: __SerdeContext): TagDescription
if (output[_LBN] != null) {
contents[_LBN] = __expectString(output[_LBN]);
}
if (output.Tags === "") {
if (String(output.Tags).trim() === "") {
contents[_T] = [];
} else if (output[_T] != null && output[_T][_m] != null) {
contents[_T] = de_TagList(__getArrayIfSingleItem(output[_T][_m]), context);
Expand Down
Loading
Loading