Add an RBS signature for sigv4

[kazuyainoue0124]

I received some advice suggesting, "Why not start with aws-sigv4?" in this PR: #3150.

Following that advice, I have added type definition files to aws-sigv4.

[mullermp]

Thank you, we will review this. I think you will also need: a changelog entry, add sig/ to gemspec files, and ensure rbs test passes (see tasks/rbs.rake).

[mullermp]

@ksss may also be interested in reviewing if you'd like.

[alextwoods]

Thanks for the contribution, this is looking good!

[ksss]

• Private API types should be removed.
• The intent and syntax are different.
• Hash arguments should be supported as well as keyword arguments.
• What about RBS testing?

[kazuyainoue0124]

I replaced URI::HTTP | URI::HTTPS with untyped because using URI::HTTP | URI::HTTPS caused an RBS::NoTypeFoundError.

[mullermp]

Let me know when this is ready for re-review and I can allocate some time.

[kazuyainoue0124]

I've made changes based on your feedback. Please review the updated code at your convenience.

[ksss]

We should modify tasks/rbs.rake to run the RBS test.

[mullermp]

Is this ready for re-review from our side?

[mullermp]

Looks good and definitely an improvement!

[mullermp]

I added the sigv4 gem to testing but there's a couple failures. So I think we're really close. I'm not sure how to add Tempfile to rbs - the signature doesn't exist, and then we just need credentials/credential provider interfaces.

[ksss]

To add stdlib (e.g. tempfile) dependencies that are not in the Gemfile.lock, you need to add the manifest.yaml file.

https://dev.to/pocke/rbs-introduced-manifestyaml-2idc

[alextwoods]

Nice!

[mullermp]

Thank you @kazuyainoue0124