Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an RBS signature for sigv4 #3152

Merged
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:
bundle config set --local with 'build rbs'
bundle install

- name: Install rbs collection
run: rbs collection install

- name: Build SDK
run: bundle exec rake build

Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@

/.byebug_history
/.bundle
/.gem_rbs_collection
/.yardoc
/api-docs
/Gemfile.lock
/coverage
/rbs_collection.lock.yaml
*.gem
benchmark_report.json

Expand Down
3 changes: 3 additions & 0 deletions gems/aws-sigv4/sig/manifest.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependencies:
- name: tempfile
- name: stringio
2 changes: 1 addition & 1 deletion gems/aws-sigv4/sig/signer.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module Aws
http_method: String,
url: String | untyped,
?headers: Hash[String, String],
?body: String | IO | StringIO | File,
?body: String | IO | StringIO | Tempfile,
) -> Signature

def sign_event: (
Expand Down
2 changes: 1 addition & 1 deletion gems/aws-sigv4/spec/signer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ module Sigv4
expect(signature.headers['x-amz-content-sha256']).to be(nil)
end

it 'computes the checksum of files without loading them into memory', rbs_test: :skip do
it 'computes the checksum of files without loading them into memory' do
body = Tempfile.new('tempfile')
body.write('abc')
body.flush
Expand Down
28 changes: 28 additions & 0 deletions rbs_collection.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
sources:
- type: git
name: ruby/gem_rbs_collection
remote: https://github.com/ruby/gem_rbs_collection.git
revision: main
repo_dir: gems

path: .gem_rbs_collection

gems:
- name: addressable
jterapin marked this conversation as resolved.
Show resolved Hide resolved
ignore: true
- name: diff-lcs
ignore: true
- name: rake
ignore: true
- name: rbs
ignore: true
- name: rubocop
ignore: true
- name: stringio
ignore: false
- name: tempfile
ignore: false
- name: webmock
ignore: true
- name: yard
ignore: true
Loading