lets not pick specific python ver #312
Conversation
|
hehe, it's PR #312 |
| @@ -132,7 +132,7 @@ class PKG_TOOLS(Enum): | |||
| 'pkg_update': 'apt-get -qq update -y', | |||
| 'pkg_install': 'apt-get -qq install -y', | |||
| 'variables': { | |||
| 'python': "python3.8", | |||
| 'python': "python3", | |||
There was a problem hiding this comment.
Just explaining why this explicitly said "python3.8"...
This was set 2 years ago, in this PR: #198
back then, on some of our docker images, installing "python3" would get you python 3.6, but you could get something newer by specifying "python3.8"
We've probably stopped using those super old images, so this makes sense.
But do a census to be sure...
There are still a few other places we specify python version, if you want to do a search for "python3."
| @@ -178,7 +178,7 @@ class PKG_TOOLS(Enum): | |||
| 'pkg_update': 'zypper refresh && zypper --non-interactive patch', | |||
| 'pkg_install': 'zypper install -y', | |||
| 'variables': { | |||
| 'python': "python3.9", | |||
| 'python': "python3", | |||
There was a problem hiding this comment.
on opensuse/leap:15.3 that we're currently using, python3 == python3.6
maybe we should be updating the docker image too, so that "python3" gets us a recent version again
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.