Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lets not pick specific python ver #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lets not pick specific python ver #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions builder/core/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class PKG_TOOLS(Enum):
'pkg_update': 'apt-get -qq update -y',
'pkg_install': 'apt-get -qq install -y',
'variables': {
'python': "python3.8",
'python': "python3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just explaining why this explicitly said "python3.8"...
This was set 2 years ago, in this PR: #198

back then, on some of our docker images, installing "python3" would get you python 3.6, but you could get something newer by specifying "python3.8"

We've probably stopped using those super old images, so this makes sense.
But do a census to be sure...

There are still a few other places we specify python version, if you want to do a search for "python3."

},
},
'debian': {
Expand Down Expand Up @@ -178,7 +178,7 @@ class PKG_TOOLS(Enum):
'pkg_update': 'zypper refresh && zypper --non-interactive patch',
'pkg_install': 'zypper install -y',
'variables': {
'python': "python3.9",
'python': "python3",
Copy link
Contributor

@graebm graebm Nov 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on opensuse/leap:15.3 that we're currently using, python3 == python3.6

maybe we should be updating the docker image too, so that "python3" gets us a recent version again

},
},
'rhel': {
Expand Down
Loading