Add memory usage check to the CI #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
monthonk
force-pushed
the
check_mem_usage
branch
from
d2f5870
to
d69b19a
Compare
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
reviewed
Sep 20, 2024
| let line = line.unwrap(); | ||
| if line.contains(&args.log_filter_str) { | ||
| let iter = line.split_whitespace(); | ||
| if let Some(Ok(value)) = iter.last().map(|last| last.parse::<u64>()) { |
There was a problem hiding this comment.
shouldn't we fail with an error if we've failed to parse an int from the matching line?
There was a problem hiding this comment.
I'm not sure if that would be too fragile. There may be some lines in the log that matching the filter string by accident and I think we can just skip them.
There was a problem hiding this comment.
Let's make the matching rule stricter then? I think we won't ever be confident in benchmarking results, if we may just skip relevant metrics
Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
monthonk
force-pushed
the
check_mem_usage
branch
from
d69b19a
to
b3746db
Compare
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
A first pass to monitor Mountpoint resource utilization. This change would capture peak memory usage from each benchmark run, save them in
gh-pagesbranch, and compare the numbers to the previous commit the same way we do for performance regression check.Example for the results: https://monthonk.github.io/mountpoint-s3/dev/bench/peak_mem_usage/
Does this change impact existing behavior?
No
Does this change need a changelog entry in any of the crates?
No, benchmark change only
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).