Fix(Core): Shaman Totems should not receive Raid/Party Wide Auras

[IntelligentQuantum]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes Shaman Totems should not receive Raid/Party Wide Auras #14552

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

Didn't Test

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Shaman Totems should not receive Raid/Party Wide Auras #14552

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

Can this be made more readable? It’s not very easy to read as it is. What does critter have to do with totem though?

[Nyeriah]

Also won’t this block totems from receiving any aura? What about stoneclaw totem?

[Nyeriah]

Tested and confirmed this breaks Stoneclaw totem interaction with other totems (shield)

Video_1730583405.mp4

It no longer shields other totems

[IntelligentQuantum]

Tested and confirmed this breaks Stoneclaw totem interaction with other totems (shield)

Video_1730583405.mp4
It no longer shields other totems

tnx for test can you test it again and also it prevents critters and non-combat pets from receiving auras.

[Nyeriah]

Can test it again over the weekend. Although review is still pending (the IF can still look better, split it into two IFs for totems and pets if you need to)

[Grimdhex]

I'm agree with Nyeriah, you can use 3 if because Totem / Pets / Critters are different things. For Totem, I prefer :

if (aura->GetSpellInfo()->Id != 55277) return;

[Nyeriah]

Yes, the IF with no code in it is not looking good